Skip to content

416241072: (feat) provide further context in test results #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 2 commits into from
May 23, 2025
Merged

416241072: (feat) provide further context in test results #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af368bd
416241072: (feat) provide further context in test results
OlgaMardvilko May 23, 2025
7687367
Merge branch 'dev' into feature/ui/416241072
OlgaMardvilko May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/ui/src/app/model/testrun-status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export interface IResult {
description: string;
result: string;
recommendations?: string[];
details?: string;
required_result: RequiredResult;
}

Expand Down
5 changes: 5 additions & 0 deletions .../ui/src/app/pages/testrun/components/test-result-dialog/test-result-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
<ul class="info-steps-list">
<li *ngFor="let point of data.testResult.recommendations">{{ point }}</li>
</ul>
<div *ngIf="data.testResult.details" class="details-info">
<p class="info-label">Details</p>
<p class="info-details">{{ data.testResult.details }}</p>
<p></p>
</div>
</section>
</mat-dialog-content>
<mat-dialog-actions align="end" class="actions-container">
Expand Down
7 changes: 6 additions & 1 deletion .../ui/src/app/pages/testrun/components/test-result-dialog/test-result-dialog.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,19 @@ mat-dialog-content.content-container {
padding: 32px 48px;
}

.info-steps-list {
.info-steps-list,
.info-details {
margin: 0;
padding-left: 24px;
font-size: 16px;
line-height: 24px;
letter-spacing: 0;
}

.details-info {
margin-top: 16px;
}

mat-dialog-actions.actions-container {
padding: 18px 36px 26px;
}
Expand Down
7 changes: 5 additions & 2 deletions modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@
<mat-header-cell mat-header-cell *matHeaderCellDef>
Description
</mat-header-cell>
<mat-cell mat-cell *matCellDef="let element">
{{ element.description }}
<mat-cell mat-cell *matCellDef="let element" class="cell-addition-info">
<p class="description-info">{{ element.description }}</p>
<p *ngIf="element.details" class="details-info">
{{ element.details }}
</p>
</mat-cell>
</ng-container>

Expand Down
18 changes: 18 additions & 0 deletions modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,24 @@ mat-header-cell {
font-weight: 700;
}

.cell-addition-info {
display: flex;
flex-direction: column;
align-items: flex-start;

p {
margin: 0;
}

.description-info {
font-weight: bold;
}

.details-info {
margin-top: 6px;
}
}

.clickable-icon {
display: flex;
flex-shrink: 0;
Expand Down