Change stop method to async

framework/python/src/api/api.py

@@ -15,6 +15,7 @@
 from fastapi import (FastAPI, APIRouter, Response, Request, status, UploadFile)
 from fastapi.responses import FileResponse
 from fastapi.middleware.cors import CORSMiddleware
+import asyncio
 from datetime import datetime
 import json
 from json import JSONDecodeError
@@ -350,9 +351,17 @@ async def stop_testrun(self, response: Response):
       response.status_code = 404
       return self._generate_msg(False, "Testrun is not currently running")
 
-    self._testrun.stop()
+    # Launch stop in the background
+    asyncio.create_task(self._run_stop())
 
-    return self._generate_msg(True, "Testrun stopped")
+    # Return response immediately
+    return self._generate_msg(True, "Testrun stop initiated")
+
+  async def _run_stop(self):
+    try:
+      await self._testrun.stop()  # Assuming .stop is async
+    except Exception as e:
+      LOGGER.exception("Error while stopping testrun: %s", e)
 
   async def get_status(self):
     return self._testrun.get_session().to_json()

framework/python/src/core/testrun.py

@@ -382,7 +382,7 @@ def start(self):
     while True:
       time.sleep(5)
 
-  def stop(self):
+  async def stop(self):
 
     # First, change the status to stopping
     self.get_session().stop()

modules/ui/src/app/model/testrun-status.ts

@@ -72,6 +72,7 @@ export enum StatusOfTestrun {
   WaitingForDevice = 'Waiting for Device',
   Cancelled = 'Cancelled',
   Cancelling = 'Cancelling',
+  Stopping = 'Stopping',
   Failed = 'Failed',
   CompliantLimited = 'Compliant (Limited)',
   CompliantHigh = 'Compliant (High)',

modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.html

@@ -66,6 +66,10 @@
         *ngSwitchCase="StatusOfTestrun.Cancelling"
         [ngTemplateOutlet]="Cancelling">
       </ng-container>
+      <ng-container
+        *ngSwitchCase="StatusOfTestrun.Stopping"
+        [ngTemplateOutlet]="Cancelling">
+      </ng-container>
     </div>
 
     <ng-container

modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.spec.ts

@@ -62,6 +62,7 @@ describe('ProgressStatusCardComponent', () => {
         StatusOfTestrun.WaitingForDevice,
         StatusOfTestrun.Monitoring,
         StatusOfTestrun.Cancelling,
+        StatusOfTestrun.Stopping,
       ];
 
       const statusesForCompletedSuccessClass = [

modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.ts

@@ -70,7 +70,9 @@ export class TestrunStatusCardComponent {
   } {
     return {
       progress:
-        this.isProgressStatus(status) || status === StatusOfTestrun.Cancelling,
+        this.isProgressStatus(status) ||
+        status === StatusOfTestrun.Cancelling ||
+        status === StatusOfTestrun.Stopping,
       'completed-success':
         (result === ResultOfTestrun.Compliant &&
           status === StatusOfTestrun.Complete) ||
@@ -92,6 +94,7 @@ export class TestrunStatusCardComponent {
       data.status === StatusOfTestrun.InProgress ||
       data.status === StatusOfTestrun.Cancelled ||
       data.status === StatusOfTestrun.Cancelling ||
+      data.status === StatusOfTestrun.Stopping ||
       data.finished
     ) {
       if (
@@ -126,6 +129,9 @@ export class TestrunStatusCardComponent {
     ) {
       return data.result!;
     }
+    if (data.status === StatusOfTestrun.Stopping) {
+      return StatusOfTestrun.Cancelling;
+    }
     return data.status;
   }
 

modules/ui/src/app/pages/testrun/testrun.component.html

@@ -20,6 +20,7 @@
         isTestrunInProgress(data.status) ||
         data.status === StatusOfTestrun.Cancelled ||
         data.status === StatusOfTestrun.Cancelling ||
+        data.status === StatusOfTestrun.Stopping ||
         data.finished
       ">
       <mat-toolbar class="progress-toolbar">
@@ -115,7 +116,8 @@
         hasDevices === false ||
         isAllDevicesOutdated === true ||
         isTestrunInProgress(systemStatus?.status) ||
-        systemStatus?.status === StatusOfTestrun.Cancelling
+        systemStatus?.status === StatusOfTestrun.Cancelling ||
+        systemStatus?.status === StatusOfTestrun.Stopping
       "
       (click)="openTestRunModal(vm.testModules)"
       mat-flat-button>

modules/ui/src/app/store/effects.spec.ts

@@ -37,7 +37,6 @@ import {
   MOCK_PROGRESS_DATA_WAITING_FOR_DEVICE,
 } from '../mocks/testrun.mock';
 import {
-  fetchSystemStatus,
   fetchSystemStatusSuccess,
   setReports,
   setStatus,
@@ -339,7 +338,6 @@ describe('Effects', () => {
 
       effects.onStopTestrun$.subscribe(() => {
         expect(testRunServiceMock.stopTestrun).toHaveBeenCalled();
-        expect(dispatchSpy).toHaveBeenCalledWith(fetchSystemStatus());
         done();
       });
     });

modules/ui/src/app/store/effects.ts

@@ -38,7 +38,6 @@ import {
   TestrunStatus,
 } from '../model/testrun-status';
 import {
-  fetchSystemStatus,
   fetchSystemStatusSuccess,
   setIsTestingComplete,
   setReports,
@@ -137,7 +136,8 @@ export class AppEffects {
       map(({ systemStatus }) => {
         const isInProgressDevice =
           this.testrunService.testrunInProgress(systemStatus?.status) ||
-          systemStatus.status === StatusOfTestrun.Cancelling;
+          systemStatus.status === StatusOfTestrun.Cancelling ||
+          systemStatus.status === StatusOfTestrun.Stopping;
         return AppActions.setDeviceInProgress({
           device: isInProgressDevice ? systemStatus.device : null,
         });
@@ -163,14 +163,7 @@ export class AppEffects {
       return this.actions$.pipe(
         ofType(AppActions.setIsStopTestrun),
         switchMap(() => {
-          this.store.dispatch(stopInterval());
-          return this.testrunService.stopTestrun().pipe(
-            map(stopped => {
-              if (stopped) {
-                this.store.dispatch(fetchSystemStatus());
-              }
-            })
-          );
+          return this.testrunService.stopTestrun();
         })
       );
     },
@@ -200,7 +193,10 @@ export class AppEffects {
               isTestingComplete: this.isTestrunFinished(systemStatus.status),
             })
           );
-          if (this.testrunService.testrunInProgress(systemStatus.status)) {
+          if (
+            this.testrunService.testrunInProgress(systemStatus.status) ||
+            systemStatus.status === StatusOfTestrun.Stopping
+          ) {
             this.pullingSystemStatusData();
             this.fetchInternetConnection();
           } else if (