Merge main into dev (release v2.2 fixes) #1279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update requirements.txt (#429) Signed-off-by: J Boddey <boddey@google.com> * Remove in progress status after discovery (#422) * Add steps to resolve to PDF report (#411) * Add progress for steps to resolve * Formatting * Remove print statements * Allow for no steps to resolve * Add multipage * Fix multipage * Fix config * update report unit tests --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Bump ejs in /modules/ui in the npm_and_yarn group across 1 directory (#428) Bumps the npm_and_yarn group with 1 update in the /modules/ui directory: [ejs](https://github.com/mde/ejs). Updates `ejs` from 3.1.9 to 3.1.10 - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * For delete report take mac_addr from upper level (#436) * Update dependencies (#435) * Add new mac addr field for report deleting (#432) * Bump version to v1.2.2 (#433) * fix: replace Feature Not Present to Feature Not Detected (#445) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix PDF alignment (#441) * Do not remove form control on destroy as it causes error; call system/config on settings open (#442) * Fix some pylint issues (#437) * Update documentation (#448) * Update documentation * Update docs * V1.3 (#393) * Adds version analytics event (#306) * Techdebt: adds state for testrun page (#392) * Fix tests (#397) * Fix tests * Update node version * 331379891: (feat) disable connection settings when testrun is in progress (#371) * 331379891: (feat) disable connection settings when testrun is in progress * 331379891: (fix) include more testrun results as progress * 331379891: (fix) fix spelling * 333349715: (fix) GAR 1.3 The disabled system settings panel contains a focusable element (#388) Co-authored-by: Volha Mardvilka <mardvilka@google.com> --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Disable device item if device in progress (#370) * Adds ga to track testrun initiation (#415) Adds ga ti track testrun initiation * Fix function return value (#421) * Fix redirect + adds google analytics (#420) * Adds certificates drawer component with list of certificates (#414) Adds certificates drawer component with list of certificates. Upload and delete is out of scope * List modules (#425) * Adds delete certificate (#424) Adds delete certificate * Adds class for links to track report type on download; adds event when download report is clicked on progress page (#434) * Adds upload certificate (#431) * Adds upload certificate * move delete functionality to certificates store * Catch error on report/certificate deletion (#438) * Fix button size; fix text-overflow (#440) * Adds focus on next or close button when certificate is deleted (#439) * Adds focus on next or close button when certificate is deleted * Enable test modules for initiate test run dialog (#400) Enable test modules for initiate test run dialog * Add steps to resolve to PDF report (#411) * Add progress for steps to resolve * Formatting * Remove print statements * Allow for no steps to resolve * Add multipage * Fix multipage * Fix config * update report unit tests --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Add new mac addr field for report deleting (#432) * Bump version to v1.2.2 (#433) * 337012359: (feat) add snackBar with wait or stop testrun (#444) * 337012359: (feat) add snackBar with wait or stop testrun * 337012359: (fix) update to fix failed tests * 337012359: (fix) add fix for deletCertificate test --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Feature/port stats (#430) * Add port speed and duplex tests Add unit tests for port stats testing Add place holder for ip port link test * Add ethtool to system dependencies Restructure conn stats methods and tests Resolve port stat information for link test * Fix runtime issue * Implement link test Fix unit tests Misc port stats updates * fix pylint issues * update readme * pylint fixes --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: J Boddey <boddey@google.com> * 339315842: (feat) add risk assessment tab (#450) * 339315842: (feat) add risk assessment tab * 339315842: (feat) add risk assessment tab --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Add steps to resolve to PDF report (#411) * Add progress for steps to resolve * Formatting * Remove print statements * Allow for no steps to resolve * Add multipage * Fix multipage * Fix config * update report unit tests --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Add new mac addr field for report deleting (#432) * Remove rebase error --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: jhughesbiot <50999916+jhughesbiot@users.noreply.github.com> * Rename "history" to "reports" (#456) * Rename "device-repository" to "devices" (#455) * Change certificates endpoints (#458) * 339311887: (feat) display saved risk profile (#460) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix ui defects (#459) * 340835710: (fix) [Risk assessment] change page view when callout is visible (#461) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix style to allow screen reader to read label (#462) * Updaate device test module configuration from api start endpoint (#463) * Add get profiles format endpoint (#465) * 339311250: (feat) delete risk profile (#466) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 341254121: (fix) [a11y] add item name for aria-labels delete and copy buttons (#467) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Make testing statuses available outside of Testing Tab (#468) * Adds timeout token * Status is available on all pages; Removed unused field isTestrunStarted - actual status is available * Validate CA certificate on FE (#464) * Adds validation on certificate upload * Show notification when error happens * 341901606: (fix) [GAR 1.6]: update for arrows usage on risk profile (#471) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Adds space in certificate name regexp (#469) * 342096458: (fix) [GAR 1.3] add focus trap to certificates panel to prevent move focus to risk profile (#472) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * The focus is not moved to the snackbar with certificate validation rule (#470) * Adds class to fix focus flow * Changes the delay according to string length * Adds file name in error message (#473) * Add certificate endpoints (#451) * Adds version analytics event (#306) * Techdebt: adds state for testrun page (#392) * Fix tests (#397) * Fix tests * Update node version * 331379891: (feat) disable connection settings when testrun is in progress (#371) * 331379891: (feat) disable connection settings when testrun is in progress * 331379891: (fix) include more testrun results as progress * 331379891: (fix) fix spelling * 333349715: (fix) GAR 1.3 The disabled system settings panel contains a focusable element (#388) Co-authored-by: Volha Mardvilka <mardvilka@google.com> --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Disable device item if device in progress (#370) * Adds ga to track testrun initiation (#415) Adds ga ti track testrun initiation * Certs progress * Add list and upload cert endpoint * Add delete certificate endpoint * Update cert response codes * Upgrade dependency --------- Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix modify devices test (#449) * Fix modify devices * Remove excess logging * "Waiting for Device" :the snack bar appears on all pages (#474) * Make waiting for device snackbar global * Do not dismiss snack bar onDestroy * Rename testrun component (#480) * Rename settings component (#476) * Rename testrun component (#477) * Rename testrun component * Improve API test coverage (#291) * Improve API test coverage * Add timeouts * Improve coverage * Increase API timeout Signed-off-by: J Boddey <boddey@google.com> * Pylint fixes * Disable broken tests * Fix skip * Disable broken tests * Fix test --------- Signed-off-by: J Boddey <boddey@google.com> * Remove certificate if BE error happens (#484) * Add cert status (#478) * Add ethtool to make and docs (#483) * Add exception handling to certificate upload (#479) * Add cert status * Add exception handling to cert upload * Add get profiles format endpoint (#475) * Add get profiles format endpoint * Update risk assessment format * Re-add modules endpoint * Update session.py Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> * Reduce locations of Testrun version (#453) * Reduce locations of Testrun version * Update from comments * Resolve make control file --------- Signed-off-by: J Boddey <boddey@google.com> * Allow stop testrun from any other page (#487) * Feature/tls client protocols (#485) * Add methods to allow known protocols that dont fit into the strict tls client detection methods Add QUIC protocol to approved protocols Start moving unit tests to a docker container for consistency * Fix client connections protocol method script Downgrade cryptography and pyOpenSSL libraries Move unit testing into docker for TLS module * Misc cleanup and pylint issues --------- Co-authored-by: J Boddey <boddey@google.com> * The focus goes to the main page element after adding the ceriticate (#489) * Focus first interactive element in cert container when cert snack bar closed * The snack bar with test attempt status appears if the user is not on Testing page (#488) * Remove testrun status snack bar * Update consent form (#490) * Adds opt out checkbox * Adds announce when settings or certificate panel is opened (#493) * Set status code on failed cert upload (#491) * Add risk profiles (#486) * Add get profiles format endpoint * Update risk assessment format * Re-add modules endpoint * Work on profiles * Add load profiles format * Pylint * Add check status --------- Signed-off-by: J Boddey <boddey@google.com> * Add test count to PDF report (#482) * Add test count to PDF report * Fix pylint issue * Exclude error --------- Signed-off-by: J Boddey <boddey@google.com> * Change network mode on network modules to fix gateway routing (#495) * 342365574: (feat) display info about Risk Assessment during testing (#492) * 342365574: (feat) display info about Risk Assessment during testing * 342365574: (fix) change to show Risk Assessment callout only on InProgress --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Updates status with data from start response (#494) * 341966862: (feat) display info about risk assessment in welcome modal (#496) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Adds download zip window (#497) * 344874424: (fix) disable device tile in Canceling status (#500) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix/UI/345164706 (#501) * 345164706: (fix) disable start testrun btn in canceling state * 345164706: (fix) remove commented code --------- Co-authored-by: Volha Mardvilka <mardvilka@google.com> * GA option issues on the Welcome modal (#502) * Fix ga initial value * Fix label * 345202815: (fix) callout with the RA message is shown on the RA page (#503) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 345203686: (fix) update callout block view on the welcome modal (#504) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Allow UI to specify modules (#505) * Update risk assessment format (#499) * Fix issue with checking for error result (#498) * Fix issue with checking for error result * Resolve issue * Update html in test report Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> * Announce disabled state of settings panel (#506) * The Downlaod ZIP action can not be performed using the keaboard (#508) * Changes aria-label for Download Anyway button * Fix keyboard navigation for Download zip component * Add create and delete profile endpoints (#507) * Work towards creating profiles * Add delete profile endpoint * Exclude link local for arp (#418) * Add feature not detected test result (#396) * Add feature not present test result * Remove changes to tls module * Further pylint fixes * Add Feature Not Present to relevant tests * Reduce pylint limit * Change to feature not detected * Modify bacnet result * Update DNS test --------- Signed-off-by: J Boddey <boddey@google.com> * Add extension for cert upload (#510) * 340859666: (feat): display risk profile form with name field (#514) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fixes some pylint issues (#511) * Fix some pylint issues * Fix more pylint issues * bug/test_baseline (#513) * Update mac address for baseline config dynamically * fix line endings * Update device config via Testrun api * Add API to no ui mode * Fix API endpoint call * Remove mac address update Change mac address in container * Add container start command back * Skip DNS tests * Cleanup --------- Co-authored-by: J Boddey <boddey@google.com> * Attach profile to ZIP report (#518) * Work towards creating profiles * Add delete profile endpoint * Work on attaching profile to zip * Pylint * Fix zipping * Pylint fixes --------- Signed-off-by: J Boddey <boddey@google.com> * Generate Risk profile from json (#515) Generate form from json * The Downlaod ZIP action can not be performed using the keyboard (#517) * Stop propagating event to eliminate the error * Fix tests * Adds tooltip * Fix export endpoint to use POST request * Fix zip download --------- Co-authored-by: Jacob Boddey <boddey@google.com> * Add required if applicable (#519) * WIP: Add required if applicable * Fix bug with TLS client test * Update TLS results * Fix styles for helperbird (#524) * Form from json validation (#523) * Adds field validation * Fix vulnerabilities in dependencies (#526) * Enable draft button when profile name is present; enable save button when form is valid; remove discard button (#530) * Correct result on tls client test (#528) * Add informational and fnd to report (#527) * Mark fields required when trimmed value is empty (#529) * Update requests dependency (#525) * Remove debug artifact (#531) * Fix scroll area on reports page (#532) * Announce risk form open; focus first element in container (#536) * Fix validation; change element for text-long (#538) * 345258435: (feat) display expired certificate (#539) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 348187954: (fix) update callouts position on the small window size (#540) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 348356236: (fix) add tooltips for icons without any accompanying text (#541) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 348353479: (fix) add tooltip for the download zip button using the keyboard (#542) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * 348361925: (fix) add helper text for mandatory profile name field (#543) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Save new risk profile (#533) * Save new risk profile * Clear and close form after profile saved * Adds status valid for save profile * Fix DNS report when DNS packet is missing the qname property (#546) * Adds edit risk profile (#544) * Refactor delete form: rename it to simple dialog as it is not used for delete anymore * Adds edit risk profile * Fix autozise (#547) * Feature/risk profile (#522) * Update risk profile * Add unit tests for risk profile Fix service nmap unit test * Add unit tests for risk profile Fix service nmap unit test * Update api and session for new risk profile methods * pylint * pylint * Fix some pylint * Fix more pylint * Fix some bugs * Update risk profile logic (#535) * Update risk profile logic * Update test profiles Remove duplicate test file Cleanup temp test files * Remove categories from profile * Update expiration check to account for leap years * Update risk assessment questions * Update dependency * Add missing question * Update format and add error handling --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Jacob Boddey <boddey@google.com> * Adds save draft (#549) Co-authored-by: Sofia Kurilova <kurilova@google.com> * 346351108: (feat) display risk assessment result (#553) * Close form after selected risk profile was deleted (#554) Co-authored-by: Sofia Kurilova <kurilova@google.com> * Fix error when updating profile (#555) * Render informational result correctly (#551) * Re-add method for exporting profle (#550) * Fix bug when failed to fetch latest version (#548) * 349769454: (fix) update size on the empty reports page to prevent overlapping (#557) * Fix bad multiple ip report when no ip requested (#556) * Fix Duplicate Certificate Names (#545) * Check for existing common name before uploading new cert Misc pylint updates * Re-add missing session content --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Jacob Boddey <boddey@google.com> * Changes the icon; adds create date (#552) * 349783464: (fix) add styles for selected elements and fix form size on RA (#558) * 349793005: (fix) change focus to profile form to scroll up on opening profile (#559) * Return focus on create button when new profile created; return focus on profile is profile was edited (#560) * Small refactoring; update validators on selected profile update and on profile list update (#564) * Enables save and draft button for edit mode (#565) * Validate multi select form group on last checkbox tab press (#566) * Remove copy button (#567) * Bug/bacnet device (#568) * Change BACnet device detection validation Add unit tests * Fix runtime * cleanup * Update unit tests to match runtime types * Show only valid profile in modal; fix condition to not download profile if redirect button clicked (#569) * Fix bug when saving draft profile (#563) * Fix bug when saving draft * Remove risk when status changes to draft * Re-add exception handling * Fix formatting : * Update questions before calculating risk * Update unit testing * Update unit testing * Invoke risk profile update method in favor of manually updating properties in session * Update risk after update and fix type error * Update risk correctly --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Focus title or first element in container when navigation is triggered by enter (#570) * Adds aria label and tooltip to risk profile icons (#572) * Add profile PDF (#562) * Work on pdf * Work on profile PDF * Fix risk answer formatting * Downgrade weasyprint * Remove duplicate line * Update risk assessment after review * Fix profile format undefined * Update zip file to use /tmp directory (#571) Update device report folder Update file paths to use old and new patterns Co-authored-by: J Boddey <boddey@google.com> * Remove cert from session after delete request (#575) * Fix error when only draft profiles are exist (#576) * Focus fix; fix profile status icon (#579) * Fix focus after page is opened * Fix profile status * Support longer string answers in profile PDF (#578) * Add extra spacing for long string answers * Format JSON * Cleanup old test devices from runtime (#583) * 351758698: (fix) update app version styles to meet design on expanded nav (#586) * Update risk profile description (#582) * Bump version for release (#584) * Remove skipped result (#580) * Prevent creating device with duplicate manufacturer and model (#581) * Prevent duplicate mf and model * Change error message to be more precise * Fix logic * Remove profile from runtime once included in ZIP (#577) * Remove profile after ZIP creation * Create /tmp dir for results Copy test results and profile to results dir Zip results dir and cleanup --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Do not show settings callout if there are no interfaces and saved settings (#587) * Fix modbus results (#588) * Don't show error if config is empty; don't show settings callout when settings are not empty after saving (#589) * Catch error to proceed with device creation/editing (#592) * Remove output logging from OS level commands (#594) * Fix cancel after monitor bug and add testrun.log (#595) * Fix step 1 callout error (#593) * Fix GAR bug with cert upload (#590) * Change exception logic on cert upload * Fix error logic * Update documentation (#591) * Work on docs changes * Update docs * Update roadmap * Update docs * Update docs * Remove dev README.md * Remove skipped from docs * Add exception handling to timestamp parsing (#598) * Change exception logic on cert upload * Fix error logic * Add exception handling to timestamp parse * Stick button to the bottom of risk page (#574) * Adds copy of risk profile (#573) * Lint fix * Set testrun IDLE status if report of finished test run is removed (#585) * Adds Discard risk profile (#596) * Load test modules dynamically (#597) * Update download zip modal: add link to Risk Profiles, remove redirect button, rename download button, add No Profile option (#599) * 351338001: (feat) update rule for the third step message (#600) * 347009372: (feat) add selector for profile options for GA4 (#604) * Adds tooltip for copy and delete; show "same name" error when more than one copy is created (#606) * 346999760: (feat) [GA4] Track CA Certificates (#607) * 353476778: (fix) GAR 2.11 change for prevent risk profile tiles overlap (#609) * If profile is editing, return focus on profile (#612) * Change title for save profile dialog according to type of profile (#610) * Get reports when app is opened and when report page is opened; change status if testrun does not exist in reports; do not change status if testrun is just finished but not in reports yet (#613) * Show tooltip only on keyboard or hover (#614) * Update condition as report field is unique (#615) * Expired profile profile (#619) * Use device mac_addr if report mac_addr is missing (#622) * get system network interfaces util func * test get_sys_interfaces * pylint * get all network interfaces on session start * dicts diff * detect network adapter change * pylint * logging * Add ws server * Add MQTT protocol * Upgrade ws server * paho-mqtt dependency * getting docker container IP by container name * MQTT client class * Fix pylint * rename mqtt client logger * APScheduler * initializing the client inside the testrun object * pylint * check networks adapters in background * remove extra lines at the end of a file * rename mgtt logger * move network_adapters_checker to network_orchestrator * Adds mqtt client, adds pop up when new adapter is available (#603) * Fix some pylint issues (#620) * Disabled test results (#212) * Better handling of disbled tests Add dns and tls tests back in disabled state * pyling fixes * Fix subscriptable error * Re-add old tests as informational --------- Co-authored-by: J Boddey <boddey@google.com> * remove get ip of docker container because it is not necessary * Fix individual test disabling when run from the UI (#629) * Fix individual test disabling when run from the UI * Remove disabled result for now --------- Co-authored-by: Jacob Boddey <boddey@google.com> * Update package.yml (#624) Signed-off-by: J Boddey <boddey@google.com> * Added risk profile api testing (#628) * added tests for profile endpoints * Modified test_start_testrun_started_successfully payload to match the expected json format, updated the profile endpoints tests * fixed the pylint errors from test_api.py * fixed few more pylint errors * Expired profile profile (#619) * Use device mac_addr if report mac_addr is missing (#622) * Fix some pylint issues (#620) * Disabled test results (#212) * Better handling of disbled tests Add dns and tls tests back in disabled state * pyling fixes * Fix subscriptable error * Re-add old tests as informational --------- Co-authored-by: J Boddey <boddey@google.com> * added try-except block to delete_all_profiles() * Revert session file back * Add new line * Update api testing * updated the tests for profile endpoint, added a new fixture (add_profile) to create a profile * Updated profile endpoints: created a new fixture add_profile for creating profiles * Fix pylint * Fix pylint * Fix pylint issues --------- Co-authored-by: Sofia Kurilova <kurilova@google.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Adds close button for expired profile (#635) * Copy changes from hotfix 1.3.1 to dev (#631) * Copy changes from hotfix 1.3.1 to dev * Add pydyf version Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> * Inform FE about a new network adapter discovered( rename mqtt topic according to naming convention) (#634) * rename mqtt topic * Rename topic in ui --------- Co-authored-by: kurilova <sonnycactus@gmail.com> Co-authored-by: J Boddey <boddey@google.com> * Fix network only mode issues (#617) Co-authored-by: J Boddey <boddey@google.com> * Update all unit tests to work within the runtime environment (#611) * Update all unit tests to work within the runtime environment * Fix some formatting * fix line endings * update gitignore * Fix binary files in dockerfile * Change unit tests to run from testrun root directory * Run unit tests in actions * Fix pylint issues * Change command in actions * Update testing.yml Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Jacob Boddey <boddey@google.com> * Feature/dns report update (#637) * Update DNS module report Downgrade python packages for tls module * Fix header * pylint fixes * refactor func to handle case when network interface not exists * set test result "Error" * check device connected * thread for monitoring device connection * Minor changes * check the device connection only before each test * Adds tooltip (#638) Adds tooltip * send testrun status using mqtt * remove duplicatied line * refactor setting remaining tests to error * pylint * Fix focus after profile delete - track by name (#640) Fix focus after profile delete - track by name * Update the requests dependency (#643) * Update requests dependency * Update requests dependency * Update dependency in TLS test * Update docker dependency --------- Signed-off-by: J Boddey <boddey@google.com> * Revert "Expired profile (#619)" (#645) Prevent opening of Expired risk profile * Improve documentation (#639) * Improve docs * Remove paragraph * Text changes * Fix text for the BE error * Change tooltip (#650) * Change tooltip * Allows draft profiles to become expired (#636) * Allow draft profiles to expire * Move status method into risk profile class * Use existing method * Check for expiry in validate method * Remove unused variable * Build UI during package instead of install (#621) * Build UI during package * Fix local build * Install npm * Remove duplicate build message * Fix ESLint * Fix script * Modify scripts * Improve scripts * Fix copy command * Try installing package * Depend on package job * Add sudo * Add sudo * Troubleshoot * Fix workflow * Checkout source for prepare command * Built ui within a container * Mount src files for build instead of static copy in build image * Attempt to fix actions * Remove manual build container cleanup methods * undo failed attempts to fix actions * Fix path * Remove -it flag --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: kurilova <sonnycactus@gmail.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Feature/risk in selected (#654) * Adds risk to selected value * Adds risk to selected value --------- Co-authored-by: J Boddey <boddey@google.com> * Show risk for each question in the Risk profile (#647) * Show risk for each question in the Risk profile * set top position to 0 --------- Co-authored-by: J Boddey <boddey@google.com> * Show internet connection (#653) * MQTT show internet connection * remove unused method * Change tooltip for internet icon (#656) * Change tooltip for internet icon * Remove unused import' --------- Co-authored-by: Jacob Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Sofia Kurilova <kurilova@google.com> * bug/modbus_constructor (#657) * Pin all required packages Update modbus constructor to prevent error Add full trace logging for general errors in tests * Fix pylint issue --------- Co-authored-by: Jacob Boddey <boddey@google.com> * Use mqtt service instead of calling GET /status every 5 seconds. (#644) * Use mqtt service instead of calling GET /status every 5 seconds. * Adds tooltip (#638) Adds tooltip * Fix focus after profile delete - track by name (#640) Fix focus after profile delete - track by name * Update the requests dependency (#643) * Update requests dependency * Update requests dependency * Update dependency in TLS test * Update docker dependency --------- Signed-off-by: J Boddey <boddey@google.com> * remove unused output * encode mqtt message to json * Revert "Expired profile (#619)" (#645) Prevent opening of Expired risk profile * Improve documentation (#639) * Improve docs * Remove paragraph * Text changes * Fix text for the BE error * Change tooltip (#650) * Change tooltip * Allows draft profiles to become expired (#636) * Allow draft profiles to expire * Move status method into risk profile class * Use existing method * Check for expiry in validate method * Remove unused variable * Build UI during package instead of install (#621) * Build UI during package * Fix local build * Install npm * Remove duplicate build message * Fix ESLint * Fix script * Modify scripts * Improve scripts * Fix copy command * Try installing package * Depend on package job * Add sudo * Add sudo * Troubleshoot * Fix workflow * Checkout source for prepare command * Built ui within a container * Mount src files for build instead of static copy in build image * Attempt to fix actions * Remove manual build container cleanup methods * undo failed attempts to fix actions * Fix path * Remove -it flag --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: kurilova <sonnycactus@gmail.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Feature/risk in selected (#654) * Adds risk to selected value * Adds risk to selected value --------- Co-authored-by: J Boddey <boddey@google.com> * Show risk for each question in the Risk profile (#647) * Show risk for each question in the Risk profile * set top position to 0 --------- Co-authored-by: J Boddey <boddey@google.com> * Use mqtt service instead of calling GET /status every 5 seconds. * Use mqtt service instead of calling GET /status every 5 seconds. * Use mqtt service instead of calling GET /status every 5 seconds. * pylint --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Adds test statuses (#661) * Ignore folders when loading certs (#660) * Remove scorecard schedule and bump version (#659) * Allow ICMP response to DHCP messages in DHCP snooping test (#608) * Allow ICMP response to DHCP messages * Bug/unit test runtime (#655) * Change base test module startup to allow setup script to run independent of module startup process Update connection_module to allow for unit testing Update unit test run script to use new process * enable all unit tests update google cert * Remove binary fix lines from docker files pylint updates * pylint updates --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * The risk profile saved with old format is shown improperly while loading based on a new format (#664) * Fill only fields that are present in profile * GAR : The alt text for the expired risk profile should be communicated on Enter key (#662) * Change Expired profile title on Enter; announce Expired profile title on Enter * Update wording of tls cipher results (#671) * Show error message if provided; show default message if no (#680) * Test install on supported operating systems (#675) * Test install on multiple versions * Update step names * Remove recommendations on error (#674) * Tests for API (#649) * changed the tests order in test_api.py * added tests for '/system/config' POST endpoint * added the tests for 'system/shutdown' endpoint * added the test for GET '/reports' endpoint, updated 'test_update_system_config_invalid_config' to return error 400 * Check for missing fields Signed-off-by: J Boddey <boddey@google.com> * added tests for delete profile (404, 400), added tests for create and update profile (400), added test 'run_test_and_get_report' skipped due to blocking during testing phase * added a new json file in '/testing/api/' used in 400 error tests * added error handling if 'name' and 'questions' not in profile json * fixed pylint * Added tests when update is available and 500 status code for '/system/version', test for system/modules * added responses library in requirements.txt * fixed the requested changes in api.py * Renamed the load_profile method to load_json and changed the logic to allow to load any json based on file name and relative path, corrected the new lines issues * updated restore_config fixture to run after the test * added test for create/update profile (500 error) * fixed pylint * fixed spacing, removed get_report_one_report * added tests: 500 error for delete '/profiles', 500 error for 'profles/format', 400, 404, 409 for '/system/start' * modified the tests for 500 response * added new profile with missing 'answer' * removed the tests with mock response * Update NTP report (#666) * Update NTP report * cleanup imports * pylint updates * modified update profile for bad request * changed validate_profile_json: handling empty spaces in name and question, handle if 'risk' field missing if status is 'Valid' * updated the requested changes * Add further profile validation * Fix pylint issues * Fix profile tests * Move validation to session * Fix pylint issue Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Fix a delay in the internet connectivity check (#669) * Add a timeout to the command * move single-intf check to scheduler * add timeout arg to run_command * move jobs to constructor * fping for internet connection checking * Update internet connection when device is In Progress, Monitoring, Waiting for Device status (#677) * Update internet connection when device is In Progress, Monitoring, Waiting for Device status * check if interface physically connected * Revert "fping for internet connection checking" --------- Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> Co-authored-by: Sofia Kurilova <kurilova@google.com> * Check if device folder already exists (#678) * Check if device folder already exists * Fix error message * Fix pylint issue * Remove debug mqtt logs (#692) --------- Signed-off-by: J Boddey <boddey@google.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com> Co-authored-by: jhughesbiot <50999916+jhughesbiot@users.noreply.github.com> Co-authored-by: Sofia Kurilova <kurilova@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> Co-authored-by: Marius <86727846+MariusBaldovin@users.noreply.github.com>
* No update from BE of test status results during testrun (#761) * Fix host; fix status update * Fix css property name * Fix text for High risk profile save window (#762) * Focus selected item on save (#754) * Focus first interactive element on redirect to risk assessment (#763) * Adds dynamic top property to callouts (#765) * Added test for 'system/testpacks' endpoint, fixed typing error in api.py (#767) * 362959152: (feat) add testing complete modal (#770) * Listen callout resize event, not window resize event (#769) * Add dhcp disconnect tests to qual test pack (#771) Add test descriptions to test results * Move bottom callouts to top when callout is destroyed; fix css selector (#772) * Filter devices to open device dialog if all devices are outdated (#774) * Rename column "Program" to "Assessment type" (#775) * Hide "Create" text in edit mode (#773) * Prevent default event (#777) * Show success dialog only for valid risk profile (#779) * Filter Not Started tests from test count (#778) * Change version label (#780) * Display tags for Testrun progress page (#781) * Add tags on test run page * 365728028: (feat) improve callouts (#782) * 367673910: (fix) prevent download PDF report button focused twice on completed testing modal (#785) * Fix tags (#786) * Console errors on starting the test attempt (#784) * Fix error "cannot read property of null" in console --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * 366014294: (feat) update callouts logic (#787) * Destroy "waiting for device" snackbar when status changed (#788) * Mark dirty only multi select control when tab navigation (#789) * Adds focus flow after closing download zip/testing complete dialog (#794) * Remove tooltip from link (#793) * Adds aria label; code refactoring (#790) * Add mac address filter for the device interface to single ip test (#791) * Add mac address filter for the device interface to single ip test * pylint --------- Co-authored-by: J Boddey <boddey@google.com> * Do not show "Save changes" dialog when there is no changes in profile (#799) * Risk profile completed modal: the redundant information is communicated by Screen reader (#800) * Clear announcement message on form close * Adds timeout to allow screen reader to detect changes and pronounce the changes on page * Adds button action on space click * Adds focus trap * Fix tests * 369106935: (fix) [a11y] make focused element announced (#807) * Focus with delay to allow screen reader detect changes * Focus risk assessment link when appears * 369314564: (fix) set focus after callout dismissed (#812) * 369312866: (fix) set focus after welcome modal is closed (#813) * Fix profiles page style to fit the screen * Improve style for buttons * Improve style for buttons * 358071738: (feat) prevent listening mgtt internet connect event in single port mode (#815) * remove singl_intf parameter from start_ui * single_intf config parameter * added test_get_devices_format (#809) Co-authored-by: J Boddey <boddey@google.com> * Fix condition to show dialog on name change * Fix tests * 365978129: (feat) add PDF report templates (#801) * 365978129: (feat) add PDF report templates * 365978129: (feat) keep the current report as is and create new one with updates --------- Co-authored-by: J Boddey <boddey@google.com> * 369538601: (fix) set focus to first interactive elem after stop test attempt (#818) * Remove steps to resolve from information tests (#817) * 369327155: (fix) set focus to selected risk profile if no changes on edit (#819) * Prevent default event * Adds simple dialog announcement * Fix tests * Return focus on previous active element * remove vsa tag (#823) * Fix baseline tests (#821) * Active delete button on space and enter * 369779748: (fix) add field name to validation rule for announce by Screen Reader (#826) * Add delay and fix dialog open configuration * Fix tests * 367979183: (fix) announce the result and description on completed test modal (#829) * Add optional recommendations for informational tests on pilot devices (#824) * Informational tests now produce optional recommendations * Remove debugging lines * select row on enter and space * 369542969: (fix) announce completed test modal (#832) * fixed _ load_version (#828) * Feature/tls 1.0 (#783) * Add TLS 1.0 client test * Update tls 1.0 test to account for higher versions Add tls 1.0 and 1.1 versions to binaries * pylint * Fix final result calculation * pylint * Prevent duplicate tags * Fix feature not detected result * fix device disconnected whilst monitoring (#830) * 369538601: (fix) focus first interactive elem on start or stop testrun (#837) * Adds deactivate guard for devices page * Fix audit * 369788198: (fix) validation message alignment on create device (#842) * 370729271: (fix) remove asterisks on the questions in the device flow (#843) * framework/unit_tests (#841) * Break unit tests into their own steps Update cert chain to use upgraded packages Download google public cert every time to prevent expiration * pylint * security updates * Add risk profile tests Disable report tests * Handle failed unit test result * update exit code handling * Handle failed test modules * pylint * update unit test risk profiles * 370711565: (fix) changes for informational test result (#844) * 370711565: (fix) changes for informational test result * Update informational color in report --------- Co-authored-by: Jacob Boddey <boddey@google.com> * Add role and aria-live for screen reader * 370923173: (fix) remove close button from the certificates panel (#847) * Change text in risk dialog * Revised device qualification PDF report and Pilot PDF report. The report styles will be reviewed and corrected separately. (#840) * 365978129: (feat) add PDF report templates * 365978129: (feat) keep the current report as is and create new one with updates * badges * device profile * device profile page * steps to resolve pilot * steps to resolve pilot placeholder * header macros * device profile macros header * rename header macros * pilot optional steps to resolve * remove unused files * pylint * html reports examples * Switch test modules base image to pytho:3.10-slim image (#833) Increase NTP module timeout * Change description for NTP test failure (#835) * 370012527: (feat) update PDF reports styles (#850) * 370012527: (feat) update PDF reports styles * 370012527: (feat) update PDF reports styles - update * remove unused prints * delete html examples --------- Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> * Update docs (#839) * Update docs * Update links and icons * Add header images * Update docs * Update links * Perform some refactoring (#846) * Perform some refactoring * Remove print line * Don't load template network module * Refactoring * Re-enable tests * Fix report_test.py tests (#848) * Break unit tests into their own steps Update cert chain to use upgraded packages Download google public cert every time to prevent expiration * pylint * security updates * Add risk profile tests Disable report tests * Handle failed unit test result * update exit code handling * Handle failed test modules * pylint * update unit test risk profiles * changed testing.yml * added the jinja formatting to html file for modules * fix pylint * updated testing.yml * use regex to extract the head from existing html file * removed double curly braces from body * create artifact with html reports * 369538601: (fix) set focus to first interactive elem after stop test attempt (#852) * 371506031: (fix) make the welcome modal be on top completed test modal (#853) * 366151318: (fix) add communicate steps on create device (#851) * 370941517: (fix) return focus to initial btn after cancel download zip (#856) * 371177676: (fix) set focus to the initial device if cancel on edit device (#858) * 371525395: (fix) exclude error status from count of completed test result (#863) * 371948760: (fix) set focus to first interactive elem after start testrun from device (#864) * feature/dns_module_resolved_ips (#862) * Add resolved ip addresses from dns queries to dns module report * update dns report * stop monitoring when test run is cancelled (#855) * session/remove_invalid_questions (#834) * updated _load_profiles to remove all unrecognised risk profiles questions * added the method '_remove_invalid_questions' to remove unrecognised profile questions * API tests (#766) * updated delete device endpoint to respond 404 if report is not found * fix test_delete_report_no_report * fixed failing tests * fixed json formatting * updated the profile endpoints * updates * fixed device json * 362646053: (feat) add program icons and change borders in tiles (#745) * Adds dialog if profile is successfully saved (#746) * Adds dialog if profile is successfully saved * 364545807: (fix) changes to prevent the second callout is hidden (#748) * Change dialog height on resize (#749) * When canceling deletion, Create device modal opens (#751) * Open Edit device window when delete device is cancelled * 364828484: (fix) [GAR 1.1] change program icon aria-label (#752) * fixed device json * fixed failing tests * fixed errors * fixed device json files * updates on the code * updates on devices tests * Update testing.yml Signed-off-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> * added comments to testrun fixture * fixed pylint * reverted testing.yml back to original state * updated profiles directory, small updates on code * updates * 371525174: (fix) update ui on PDF report (#866) * 371525174: (fix) update ui on PDF report * 371525174: (fix) update steps to resolve on PDF report * Fix navigation structure in PDF report (#867) * Fix navigation structure in PDF report * Fix navigation --------- Signed-off-by: J Boddey <boddey@google.com> * copy a device profile questionnaire to risk profile * device risk to risk_profile risk * page counter * bold table headers * test report duration format * 372610099: (fix) update the text for Risk assessment complete modal (#873) * fix sensitive info risk * Remove global app component store * 372804973: (fix) make risk profile names not case sensitive (#882) * 370942396: (fix) change create device errors and program styles for improve view in the helperbird (#874) Co-authored-by: J Boddey <boddey@google.com> * Adds action value instead of null, undefined, string; move common functionality in component * 369806347: (fix) improve unit tests (#887) * Send event to GA when test run is completed for Pilot program * 373617780: (fix) change to allow MAC address error text move on to next line (#889) * Answers per page calculation refactor (#884) * Send event to GA when Pilot zip is downloaded * Fix tests * 373855404: (fix) allow to change case of letters for existing profile name (#895) Co-authored-by: Sofia Kurilova <kurilova@google.com> * Device endpoints (#872) * Profiles endpoint (#870) * added add_profile fixture * updated profiles endpoints * comment update * fixed failing test * Reports endpoint (#868) * added get_timestamp to extract the 'started' field value to sue it as timestamp, updated create_report_folder * updated test_delete_report * Certificates endpoint (#861) * updated certs endpoint to copy the certs locally rather than using the API * test name update * update * updated the comments * changed the certs fixture and use parametrize to pass the cert * removed duplicate comment * Remove v from firmware version in UI (#897) * 372768360: (feat) [Settings] only device port is enabled in no internet mode (#899) * Change error message * Fix tests * Update statuses.md (#894) * Add release 2.0 fixes to dev (#879) * Fix spelling mistake in report (#902) * Hide complete dialog if test run is missing in reports * 374055268: (fix) prevent overwrite copied profile (#909) * 374055268: (fix) prevent overwrite copied profile * 374055268: (fix) prevent overwrite copied profile * Update dependencies (#903) * Update dependencies * Pin ws server --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Merge hotfix into dev (#911) * The link provided in the risk profile answers is not clickable (#908) * Adds clickable link in risk assessment questionnaire * Fix options in dropdown * Catch invalid device config nicely (#912) * Check if dhcp-1.pcap exists (#913) Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Skip first default values to display error correctly * updated package.yml to start testrun and check if successfully started (#907) * Add better error handling to port stat tests (#914) * Add extra handling for port tests * Add error checking for port tests * Normalize return value behavior --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * 374258745: (fix) [PDF report] wrap long words into the next line to prevent cutting content (#917) * Adds separate method for value * 375367968: (fix) [Setting panel] remove callout about two ports warning (#919) * 374084009: Fix error on restoring DHCP server configuration if device has no DHCP lease (#896) * Fix error with DHCP server restore * Remove log dir for test modules * Change get leases method * Revert removal of error print * updated readme.md (#926) * Upload cert - error handling (#924) * Feature/cli no UI (#916) * Add target and firmware args for no-ui option * pylint fixes * Add network only filter * Add new vars to baseline test * Cleanup arg error message * Update bad target error messaging * converted bin/testrun back to unix format (#928) * Connection/README.md (#937) * updated Readme.md for connection module * removed spaces * updated * Disable MQTT log (#930) * corrected mistake on vnc (#940) * remove dublicate tests from the TLS test module (#942) * tls/README.md (#941) * updated tls/README.md * Update README.md * updated protocol/README.md (#939) * update readme.mf for dns module (#938) * updated postman file (#865) * Scapy update to 2.6.0 (#943) * added procps package in base container (#945) * remove the mqtt debug line (#944) * Unit tests (#946) * Fix security.services.vnc test (#921) * Change test in Delete Report Dialog * Fix style * added error handling if 200~dhcp-1.pcap is empty (#949) * Add communication network type test (#950) * Add communication network type test * fix type-o --------- Co-authored-by: J Boddey <boddey@google.com> * Adds tooltip for title * Fix is based on console error * Feature/sys test timeout (#951) * Add option to override test module timeouts in system config * Add docs for new feature * pylint --------- Co-authored-by: J Boddey <boddey@google.com> * 374289627: (fix) change the report url from static to dynamic (#954) * Pin python requirements (#764) * Semi-auto pin and update of python requirements in test modules * Semi-auto pin and update of python requirements in network modules * Convert line endings * Comment out binary used to generate pinned versions * Update requirements in feature request (#958) * Update requirements and run command * Update requirements again * typo error (#961) * Conn/module_config typo errors (#959) * fix typo error * fix more typo error --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * conn/ipv6_slaac (#962) * if dhcp-1.pcap is empty or not found it should check monitor and startup pcap files for ipv6 address * update --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Fix tls error result (#963) * Add BACnet test and extend port scan (#957) * Add BACnet test and extend port scan * Add bacnet test to module * Change log to info --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Error handling for connection module (#960) * added error handling if GRPC server can't start due to port 5001 is blocked by UFW firewall * fixed typo error * update * removed firewall info --------- Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Adds coverage check * Adds coverage check * Adds coverage check * Fix floating test issue * Fix permissions of resources folder during install (#974) * Only run tests if they are included in the device's test pack (#956) * Check if test is in test pack * First commit * Fix disabling tests * Pass test pack with env var for unit tests * changed the logic to display the description when test is non compliant (#983) * fix chrony install error (#979) Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> * Error handling when lease is None (#981) * added try catch if lese is None type * added spaces * Bacnet traceback error (#989) * added conditionn to check if validate_bacnet_source * added conditionn to check if validate_bacnet_source * remove empty space * Feature/tls module report (#871) * Initialize listener every time (#990) * Merge release changes into dev (#1030) * Update Crypto and Jinja libraries (#1038) * Added debug message in case users enters an incorrect device mac address (#1044) * added debug message in case users enters an incorrect device mac address * changed from debug to info * Allow NTPv3 packets (#1048) * Re-render device profile (#1050) * Handling error if profile name contains special characters (#1043) * 389661817: (feat) change profile name validation (#1057) * Add column; change pilot text; change order of columns * 389657377: (feat) add status Starting to UI (#1062) * Add full port scan to determine any HTTPS/TLS server running on non-s… (#1055) * Remove 'v' from testing complete modal (#1063) * 384421113: Add starting status (#1032) * Pin download artifact actions (#1065) * Adds statuses for Testing complete modal * Profile export endpoint (#1052) * Fix protocol.services.bacnet (#1082) * added protocol.services.bacnet in test_packs * changed services bacnet to Informational * tr-ws/tr-ui containers (#1089) * made wifi interface available * added error handling if the ui or ws containers are started without auto-remove flag * corrections * corrections * Generating module reports using Jinja2 (#1073) * Update dependencies; increase budget * Add a disclaimer about tests affected by single interface mode (#1056) * Update TLS client description (#1097) * Set test description for module timeout (#1098) * Fix services resolving wrong ip (#1096) * 384032243: Rename test result to pilot recommendation (#1031) * fixed reports unittest (#1110) * prevent mqtt sending messages when test is not running * Fix bacnet version for devices that do not report IP address in their discovery response (#1139) * added logger if no bacnet packets are found for the object_id (#1152) * Merge release changes into dev (#1154) * fix pilot report steps to resolve * fix presence of empty steps to resolve * fix no type attribute error (#1164) * Add the "export" field to the MQTT message * "export" field to the /reports api endpoint * fix API unit tests * handle the dns.pcap missing (#1166) * DNS module bug (#1165) * fix no type attribute error * Added more dns unittests and fixed the tcpdum command in dns_module * renamed test * fix pylint --------- Co-authored-by: J Boddey <boddey@google.com> * fix the duration in pilot and qualification (#1167) Co-authored-by: J Boddey <boddey@google.com> * Use field "export" for zip download, or make url from "report" field if "export" is missing * Change host for "export" field * Fix test * Fix spelling of occurred (#1170) * Catch OS error in TLS server protocol test (#1171) * Increase timeout value for /export request * Use base64 icons instead of font for proper rendering without internet connection (#1184) * Fix html to not display font icons * Update DNS from DHCP test description (#1192) * Update DNS test description * Fix pylint issue * Update Jinja2 version * fix unit test --------- Co-authored-by: MariusBaldovin <baldovin@google.com> * fix key service not found error (#1194) * Test tests (#1177) * changed test_tests, created 2 images one for compliant on efor non compliant * updates * updates * changes * added all modules * fixes * updated package.yml to start testrun after the package has been installed * fixed test_tests workflow error * updated package.yml * updated package.yml * updates * changed package.yml in separate jobs start and verify if started * removed comments * updated package.yml * enable onlye services for testr1 and tester2 * updated package.yml * reverted package.yml to its original state * added comments * updated comments * removed push from testing.yml * updates on docker images * updated testing.yml * added tests for DNS Module * updates * Updated the scrip for starting testrun with no ui Signed-off-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> * Merge release changes into dev (#1030) * Update Crypto and Jinja libraries (#1038) * Added debug message in case users enters an incorrect device mac address (#1044) * added debug message in case users enters an incorrect device mac address * changed from debug to info * Allow NTPv3 packets (#1048) * Re-render device profile (#1050) * Handling error if profile name contains special characters (#1043) * 389661817: (feat) change profile name validation (#1057) * Add column; change pilot text; change order of columns * 389657377: (feat) add status Starting to UI (#1062) * Add full port scan to determine any HTTPS/TLS server running on non-s… (#1055) * Remove 'v' from testing complete modal (#1063) * 384421113: Add starting status (#1032) * Pin download artifact actions (#1065) * Adds statuses for Testing complete modal * Profile export endpoint (#1052) * Fix protocol.services.bacnet (#1082) * added protocol.services.bacnet in test_packs * changed services bacnet to Informational * tr-ws/tr-ui containers (#1089) * made wifi interface available * added error handling if the ui or ws containers are started without auto-remove flag * corrections * corrections * Generating module reports using Jinja2 (#1073) * Update dependencies; increase budget * Add a disclaimer about tests affected by single interface mode (#1056) * Update TLS client description (#1097) * Set test description for module timeout (#1098) * Fix services resolving wrong ip (#1096) * 384032243: Rename test result to pilot recommendation (#1031) * fixed reports unittest (#1110) * prevent mqtt sending messages when test is not running * added avirtual bacnet device * changes * changes * updates * remove logger * each test module will have its separate container * fix typo error * fix maxc address for services non compliant * save the tets tests reports into github * test1 * test2 * test3 * test4 * test5 * test6 * test7 * test8 * test9 * test10 * test11 * remove on push from workflows * renamed the files saved on github actions * fix upload test reports job * grant write permission to local/devices * remove the upload job * added for loop to build the test containers * fix for loop --------- Signed-off-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Olga Mardvilko <mardvilka@google.com> Co-authored-by: kurilova <kurilova@google.com> Co-authored-by: Aleksander <aliaksandrn@google.com> * Resolve and use device address for reads (#1215) * Fix missing bracket (#1217) * Removed Ubuntu 20.04 runner (#1243) * remove ubuntu 20.04 runner * remove 20.04 support from documentation * bug/ethtool (#1242) * Add ifconfig option for resolving port stats Add unit tests * pylint fixes * pylint fixes * fix unit testing action --------- Co-authored-by: J Boddey <boddey@google.com> * feature/allow_monitor_disconnect (#1249) * Add option to allow devices to disconnect during monitor period * update example config * Merge google material 3 changes into dev * Migrate to material 3 * Adds copyright * Apply new styles for reports table * Fix color * 378065444: (feat) apply gm3 for header (#965) * Increase budget * Adds color palette * Fix lint issues * Make palette private * Remove unused import * Fix sorting icon on hover * Adds aria-label and hover styles * Change import from 'src/theming/...' to '...' * Fix linter issues * Fix imports * Fix tests * 378065443: (feat) add gm3 for nav bar (#971) * 378065443: (feat) add gm3 for nav bar * 378065443: (feat) add gm3 for nav bar * 379246727: (fix) changes for gm3 header (#973) * 379246727: (fix) change certificate button to filled view (#980) * Adds style for focused logo * Adds style for better spacing between elements * Fix focus style; adds focus after redirect * Update version * Update version * Fix tests * Adds style for sorting; adds filter header component * 380254684: (feat) apply gm3 for filtering report (#996) * Migrate code to new angular features: signals and injection * Change budget * 382457675: (fix) changes for calendar filter issues (#1002) * Fixed issues: Buttons order Focus border Sorting button color Default sorting indicator * Fix tests * 382461850: (fix) changes for result filter (#1004) * Use signal store for certificates * Fix logic * Update dependencies * Fix error * Adds styles for snackbar * Fix liner issues * 382095919: (feat) add settings basic page * Adds Certificates page * Change empty state for reports page * 382095919: (feat) add general settings page (#1018) * Adds style for callouts; update component with signals; adds action in callout * Remove comment in file * Change style for delete certificate dialog * Fix tests * Change empty state for Devices page * Adds Copyright * 380231252: (fix) save button becomes active when any setting changes (#1029) * 382109519: (feat) apply gm3 for welcome modal (#1033) * Adds layout with devices list; adds state with no device selected * 385323565: (feat) disable general settings when testing in progress (#1035) * 385715473: (feat) add TLS callout to certificates tab (#1036) * Request settings when app is opened * Change border color for warning callout; change icon for error callouts * 386919467: (fix) make internet port disable in single mode after enable form (#1040) * 387242682: (fix) make save button available on the settings page with callouts (#1042) * 387242169: (fix) change availability of certificate page (#1045) * 387242169: (fix) change scroll on settings (#1049) * 387242169: (fix) change scroll on settings (#1049) * Device form (#1046) * BE: Changes format for devices/format FE: Form has no pages; form opens on button click. Device actions is out of scope. * Fix tests * Fix tests * 387461943: (fix) remove double scroll on device page (#1051) * 385169773: (feat) add devices input form (#1054) * Reset form values for new device * Reset form to default values * Fix test * Disable 3 dots menu for device under test; adds status for device under test * Disable save button when devices has no changes or invalid; disable cancel button when device has no changes; disable delete button for new device * Adds dialog when switching the device and there are unsaved changes * Adds tests * Change dialog width * 388235982: (fix) setting and callout fixes (#1070) * 385169778: (feat) apply search for devices (#1072) * Adds title for device under test; fix background for Outdated device * Fix tests * Fix dialog width * Fix tests * 392037156: (fix) [GM3] close form after delete device (#1077) * 392033964: (fix) [GM3] change cancel to discard on devices (#1078) * Show Discard dialog when changing the tab; show Discard dialog when clicking the Create new device * 391367079: (feat) [GM3] [Risk profiles] add empty state (#1090) * Adds layout for Risk profiles page * Disable create button while creating new device * Fix merge issues * 391367086: (feat) [GM3] add new risk profile form (#1099) * 391372198: (feat) [GM3] add risk profile search (#1100) * Update dependencies * Adds copy/delete functionality for Risk Profiles * Fix error when discard acts like cancel * 391372721: (feat) add risk profile sticky menu (#1108) * Show discard dialog when leaving the Risk Profile page; show discard dialog on profile change * 395664115: (fix) [RA] make discard disable until no changes (#1112) * Optimize changes detection * 396366298: (fix) [GM3] prevent corrupting profile if it has long name (#1121) * 396579770: (fix) set focus to correct interactive elements after delete discard profile (#1122) * 395677144: (fix) [GM3] A11Y: move button on the next line to prevent corrupting sticky menu (#1125) * Remove copy of profile on discard * 396664128: (feat) [GM3] add empty state for testing tab (#1128) * 395677144: (fix) change style to prevent hide content under sticky menu (#1129) * Adds new design for test run page for statuses before "In progress" * Clear form when Create new profile click and then Discard changes click * Fix test * 396664082: (feat) [GM3] apply changes to start testing modal (#1140) * Adds new style for Stop button; fix style for Stop test run dialog * Fix styles for tile * Improve method to check is profile is filled * Fix tests * Fix empty state for testing page * 398167706: (fix) [GM3] [Testing] change text mistake in the empty state (#1159) * Delete copy of unsaved profile without backend call * 396665821: (feat) [GM3] add testing table (#1161) * Fix bacnet version for devices that do not report IP address in their discovery response (#1139) * added logger if no bacnet packets are found for the object_id (#1152) * Merge release changes into dev (#1154) * Update design of the Stop Testrun modal * 396677540: (feat) [GM3] add steps to resolve modal (#1169) * 396676848: (feat) [GM3] add testing done (#1172) * 400924741: (fix) [GM3] [Testing] change security tag design (#1174) * Adds side button with menu * Adds tests * Change style * 396678430: (feat) [GM3] add download result options (#1180) * Change buttons text and add aria-label for "+" button * 403525535: (feat) add help tips (#1186) * 403525535: (feat) add help tips * Partially fix tests * 403525535: (feat) add unit test * 403525535: (fix) remove unused data --------- Co-authored-by: kurilova <kurilova@google.com> * 405967754: (fix) [a11y] changes for focus indicator issues (#1187) * 406180159: (fix) [a11y] change page title for testing page (#1188) * Focus Version button on Welcome modal close * Use hash location strategy * Change tabindex * Mask form pristine after settings saved * Disable side bar closing * Hide non-interactive element * Enable save button when optout field has changes * Fix tests * Remove focus trap on certificate page; remove ng-template from menu; adds tooltip on + button * Revert "Remove focus trap on certificate page; remove ng-template from menu; adds tooltip on + button" This reverts commit 82c534b. * Remove focus trap on certificate page; remove ng-template from menu; adds tooltip on + button * Change link style * Fix a11y issues on Risk Profiles page * Fix selector * Fix selector * Fix tests * Scroll only entities list; focus selected device after save; unselect device after discard * Focus first element in page content after callouts after redirect * Focus tab when general settings are saved * Change element for Clear all button * 406770411: (feat) add start testing message (#1207) * 406769857: (feat) add risk assessment message (#1209) * Disable copy of copy * 407724424: (fix) changes for risk profile message to be displayed on all pages (#1211) * 406699210: (fix) change styles for risk assessment form (#1212) * Change error status background * Fix tests * Adds Status for Pilot Assessment; make progress bar width as 100% * Fix deleting of profile * Fix tests * 407737058: (fix) hide help tip when the actions menu opens (#1216) * 407943943: (fix) open profile form when redirect from profile help tip (#1218) * 408378150: (fix) changes for broken download pdf link (#1219) * Hide Tip button when no tips available * 406766143: (feat) [Testing] show explanation for test result (#1222) * Fix side button display * Change layout * 409247193: (fix) [a11y] change focus when cancelling the start testrun (#1225) * Fix paddings; change label to placeholder * 406210966: (fix) make save button enable if any setting form field changed (#1227) * Fix style for status card, change style for Cancelling status * Fix tests * Filter navigation buttons to remove "mouse-only" style; clear search input field when user input only spaces * Change background color for cancelling status * 409241692: (fix) [a11Y] prevent opening the testing modal with selected device (#1234) * 409766744: (feat) change title for testing empty state (#1236) * Sort profiles list by date * Change layout for status card; fix progress bar * Add new device as the first element; fix focus after adding the new RA profile * Remove console.log; change the container for proper focus * 409764406: (feat) changes to show next tip step on first time user flow (#1238) * 410518000: (fix) [Settings] change showing two ports value by default (#1240) * Redirect user to settings page if no settings saved * Fix tests * 410755779: (fix) changes to move focus to the first interactive elem on opened page (#1244) * 410765201: (fix) make focus visible after the new device form was discarded (#1246) * Use simple dialog for shutdown * Fix lint issue * Do not show loading when cancelling * 410553758: (fix) move focus to the actions button after test attempt was cancelled (#1250) * Provide proper url for report download * 409765887: (feat) remove redundant copy and delete on risk assessment form (#1253) * Save consent value * Do not show error when only spaces entered * 409765421: (feat) [Testing tab] adjust spacing between columns (#1256) * Scroll to new added profile; remove console.log * 411077761: (fix) [a11Y] changes for focus on the settings page (#1258) * Close menu and focus menu button on Esc and Tab * Change label for download button * 411390117: (fix) [a11Y]: changes for zoom in issues (#1261) * Prevent default event when open filter * small update to trigger actions (#1263) * 412959654: (fix) make test modules visible on zoom in (#1264) * 412968690: (fix) change delete report popup to be the same as other delete popups (#1265) * The team of angular material recommends to use one-line hints, so for this case it's better to use approach with script as css changes can break whole component * Fix test coverage * 412962437: (fix) change testrun table view to improve on zoom in (#1268) --------- Co-authored-by: Olga Mardvilko <mardvilka@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> Co-authored-by: J Boddey <boddey@google.com> * fix the tcp/udp scans to target the correct ip address (#1269) Co-authored-by: J Boddey <boddey@google.com> * PDF report bug on device profile update (#1267) * reload the jinja templates into TestReport class when the report is re-renedered * fix pylint --------- Co-authored-by: J Boddey <boddey@google.com> * Feature/module logging (#1135) * Add log level configurations to test modules * Update docs * Update docs * pylint fix * update docs * fix doc link --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: J Boddey <boddey@google.com> * Merge branch 'main' into release/v2.2 # Conflicts: # .github/workflows/package.yml # .github/workflows/testing.yml # README.md # cmd/build_ui # docs/dev/mockoon.json # docs/dev/postman.json # docs/get_started.md # docs/virtual_machine.md # framework/python/src/api/api.py # framework/python/src/common/risk_profile.py # framework/python/src/core/session.py # framework/python/src/core/testrun.py # framework/python/src/net_orc/ip_control.py # framework/python/src/net_orc/network_orchestrator.py # framework/requirements.txt # local/system.json.example # modules/test/base/python/requirements.txt # modules/test/base/python/src/test_module.py # modules/test/conn/python/src/port_stats_util.py # modules/test/dns/python/src/dns_module.py # modules/test/services/python/src/services_module.py # modules/ui/angular.json # modules/ui/package-lock.json # modules/ui/package.json # modules/ui/src/app/app.component.html # modules/ui/src/app/app.component.scss # modules/ui/src/app/app.component.spec.ts # modules/ui/src/app/app.component.ts # modules/ui/src/app/app.module.ts # modules/ui/src/app/app.store.spec.ts # modules/ui/src/app/app.store.ts # modules/ui/src/app/components/callout/callout.component.html # modules/ui/src/app/components/callout/callout.component.scss # modules/ui/src/app/components/callout/callout.component.spec.ts # modules/ui/src/app/components/callout/callout.component.ts # modules/ui/src/app/components/device-item/device-item.component.html # modules/ui/src/app/components/device-item/device-item.component.scss # modules/ui/src/app/components/device-item/device-item.component.spec.ts # modules/ui/src/app/components/device-item/device-item.component.ts # modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts # modules/ui/src/app/components/download-report-zip/download-report-zip.component.ts # modules/ui/src/app/components/download-report/download-report.component.scss # modules/ui/src/app/components/download-zip-modal/download-zip-modal.component.scss # modules/ui/src/app/components/download-zip-modal/download-zip-modal.component.spec.ts # modules/ui/src/app/components/download-zip-modal/download-zip-modal.component.ts # modules/ui/src/app/components/dynamic-form/dynamic-form.component.html # modules/ui/src/app/components/dynamic-form/dynamic-form.component.scss # modules/ui/src/app/components/dynamic-form/dynamic-form.component.spec.ts # modules/ui/src/app/components/dynamic-form/dynamic-form.component.ts # modules/ui/src/app/components/program-type-icon/program-type-icon.component.ts # modules/ui/src/app/components/simple-dialog/simple-dialog.component.scss # modules/ui/src/app/components/simple-dialog/simple-dialog.component.ts # modules/ui/src/app/components/spinner/spinner.component.scss # modules/ui/src/app/components/stepper/stepper.component.scss # modules/ui/src/app/components/stepper/stepper.component.spec.ts # modules/ui/src/app/components/stepper/stepper.component.ts # modules/ui/src/app/components/testing-complete/testing-complete.component.spec.ts # modules/ui/src/app/components/testing-complete/testing-complete.component.ts # modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html # modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.spec.ts # modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.ts # modules/ui/src/app/components/version/version.component.ts # modules/ui/src/app/components/wifi/wifi.component.html # modules/ui/src/app/components/wifi/wifi.component.ts # modules/ui/src/app/mocks/device.mock.ts # modules/ui/src/app/mocks/profile.mock.ts # modules/ui/src/app/mocks/reports.mock.ts # modules/ui/src/app/mocks/testrun.mock.ts # modules/ui/src/app/model/device.ts # modules/ui/src/app/model/entity-action.ts # modules/ui/src/app/model/layout-type.ts # modules/ui/src/app/model/testrun-status.ts # modules/ui/src/app/pages/certificates/certificates.component.html # modules/ui/src/app/pages/certificates/certificates.component.spec.ts # modules/ui/src/app/pages/certificates/certificates.component.ts # modules/ui/src/app/pages/certificates/certificates.store.spec.ts # modules/ui/src/app/pages/certificates/certificates.store.ts # modules/ui/src/app/pages/devices/components/device-form/device.validators.ts # modules/ui/src/app/pages/devices/components/device-qualification-from/device-qualification-from.component.html # modules/ui/src/app/pages/devices/components/device-qualification-from/device-qualification-from.component.scss # modules/ui/src/app/pages/devices/components/device-qualification-from/device-qualification-from.component.spec.ts # modules/ui/src/app/pages/devices/components/device-qualification-from/device-qualification-from.component.ts # modules/ui/src/app/pages/devices/devices.component.html # modules/ui/src/app/pages/devices/devices.component.scss # modules/ui/src/app/pages/devices/devices.component.spec.ts # modules/ui/src/app/pages/devices/devices.component.ts # modules/ui/src/app/pages/devices/devices.module.ts # modules/ui/src/app/pages/devices/devices.store.spec.ts # modules/ui/src/app/pages/devices/devices.store.ts # modules/ui/src/app/pages/general-settings/general-settings.store.spec.ts # modules/ui/src/app/pages/general-settings/general-settings.store.ts # modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html # modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.spec.ts # modules/ui/src/app/pages/reports/components/filter-dialog/filter-dialog.component.scss # modules/ui/src/app/pages/reports/reports.component.html # modules/ui/src/app/pages/reports/reports.component.scss # modules/ui/src/app/pages/reports/reports.component.spec.ts # modules/ui/src/app/pages/reports/reports.component.ts # modules/ui/src/app/pages/reports/reports.module.ts # modules/ui/src/app/pages/risk-assessment/components/success-dialog/success-dialog.component.html # modules/ui/src/app/pages/risk-assessment/components/success-dialog/success-dialog.component.scss # modules/ui/src/app/pages/risk-assessment/components/success-dialog/success-dialog.component.ts # modules/ui/src/app/pages/risk-assessment/profile-form/profile-form.component.html # modules/ui/src/app/pages/risk-assessment/profile-form/profile-form.component.scss # modules/ui/src/app/pages/risk-assessment/profile-form/profile-form.component.spec.ts # modules/ui/src/app/pages/risk-assessment/profile-form/profile-form.component.ts # modules/ui/src/app/pages/risk-assessment/profile-form/profile.validators.ts # modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.html # modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.scss # modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.spec.ts # modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.ts # modules/ui/src/app/pages/risk-assessment/risk-assessment.component.html # modules/ui/src/app/pages/risk-assessment/risk-assessment.component.scss # modules/ui/src/app/pages/risk-assessment/risk-assessment.component.spec.ts # modules/ui/src/app/pages/risk-assessment/risk-assessment.component.ts # modules/ui/src/app/pages/risk-assessment/risk-assessment.store.spec.ts # modules/ui/src/app/pages/risk-assessment/risk-assessment.store.ts # modules/ui/src/app/pages/settings/components/settings-dropdown/settings-dropdown.component.scss # modules/ui/src/app/pages/settings/settings.component.html # modules/ui/src/app/pages/settings/settings.component.spec.ts # modules/ui/src/app/pages/settings/settings.component.ts # modules/ui/src/app/pages/testrun/components/download-options/download-options.component.scss # modules/ui/src/app/pages/testrun/components/download-options/download-options.component.ts # modules/ui/src/app/pages/testrun/components/testrun-initiate-form/testrun-initiate-form.component.ts # modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.html # modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.scss # modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.spec.ts # modules/ui/src/app/pages/testrun/components/testrun-status-card/testrun-status-card.component.ts # modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.html # modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.scss # modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.spec.ts # modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.ts # modules/ui/src/app/pages/testrun/testrun.component.html # modules/ui/src/app/pages/testrun/testrun.component.scss # modules/ui/src/app/pages/testrun/testrun.component.spec.ts # modules/ui/src/app/pages/testrun/testrun.component.ts # modules/ui/src/app/pages/testrun/testrun.module.ts # modules/ui/src/app/pages/testrun/testrun.store.spec.ts # modules/ui/src/app/pages/testrun/testrun.store.ts # modules/ui/src/app/services/test-run-mqtt.service.spec.ts # modules/ui/src/app/services/test-run-mqtt.service.ts # modules/ui/src/app/services/test-run.service.ts # modules/ui/src/app/store/actions.ts # modules/ui/src/app/store/effects.spec.ts # modules/ui/src/app/store/effects.ts # modules/ui/src/app/store/reducers.ts # modules/ui/src/app/store/selectors.spec.ts # modules/ui/src/app/store/selectors.ts # modules/ui/src/app/store/state.ts # modules/ui/src/index.html # modules/ui/src/styles.scss # modules/ui/src/theming/colors.scss # modules/ui/src/theming/theme.scss # modules/ui/src/theming/variables.scss # resources/devices/device_profile.json # resources/report/test_report_styles.css # resources/test_packs/pilot/report_templates/results.jinja # resources/test_packs/pilot/report_templates/summary.jinja # resources/test_packs/pilot/test_pack.py # resources/test_packs/qualification/report_templates/results.jinja # resources/test_packs/qualification/report_templates/summary.jinja # resources/test_packs/qualification/test_pack.py # testing/api/reports/report.json # testing/api/test_api.py # testing/device_configs/tester1/device_config.json # testing/device_configs/tester2/device_config.json # testing/device_configs/tester3/device_config.json # testing/tests/test_tests.py # testing/unit/conn/conn_module_test.py # testing/unit/dns/dns_module_test.py * Delete redundant changes * Bump version number * docs: update get started guide (#1277) * docs: update get started guide * Update get started guide * Update roadmap --------- Co-authored-by: Jacob Boddey <boddey@google.com> --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> Signed-off-by: J Boddey <boddey@google.com> Signed-off-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> Co-authored-by: Marius <86727846+MariusBaldovin@users.noreply.github.com> Co-authored-by: Olga Mardvilko <mardvilka@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> Co-authored-by: MariusBaldovin <baldovin@google.com>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.