Skip to content

2 loaders are displayed on the Cancelling status #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Apr 16, 2025
Merged

2 loaders are displayed on the Cancelling status #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions modules/ui/src/app/pages/testrun/testrun.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,6 @@ describe('TestrunComponent', () => {
});

describe('#stopTestrun', () => {
it('should show loader', () => {
component.stopTestrun();

expect(loaderServiceMock.setLoading).toHaveBeenCalledWith(true);
});

it('should update system status to Cancelling', () => {
store.overrideSelector(
selectSystemStatus,
Expand Down
5 changes: 1 addition & 4 deletions modules/ui/src/app/pages/testrun/testrun.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ export class TestrunComponent implements OnInit, OnDestroy {
}

public stopTestrun(): void {
this.showLoading();
this.setCancellingStatus();
this.sendCloseRequest();
}
Expand All @@ -151,9 +150,7 @@ export class TestrunComponent implements OnInit, OnDestroy {
this.focusManagerService.focusFirstElementInContainer(testrunContainer);
});
}
private showLoading() {
this.testrunStore.showLoading();
}

private sendCloseRequest() {
this.testrunStore.stopTestrun();
}
Expand Down
Loading