Skip to content

The focus issue on the Reports tab #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Mar 31, 2025
Merged

The focus issue on the Reports tab #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/ui/src/app/components/list-layout/list-layout.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@
display: block;
}

:host ::ng-deep .mat-drawer-inner-container {
overflow: hidden;
display: grid;
grid-template-rows: max-content 1fr;
}

.entity-list app-list-item:has(.selected) {
::ng-deep .list-item {
background-color: colors.$primary-container;
Expand Down Expand Up @@ -145,9 +151,3 @@
font-size: 16px;
letter-spacing: 0;
}

::ng-deep .mat-drawer-inner-container {
overflow: hidden;
display: grid;
grid-template-rows: max-content 1fr;
}
3 changes: 1 addition & 2 deletions modules/ui/src/app/pages/general-settings/general-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@
!isFormValues ||
vm.isLessThanOneInterface ||
settingsDisable ||
(settingForm.pristine &&
(analyticsForm.pristine || !optOutHasChanges))
(settingForm.pristine && analyticsForm.pristine)
">
Save
</button>
Expand Down
24 changes: 11 additions & 13 deletions modules/ui/src/app/pages/reports/components/filter-chips/filter-chips.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,15 @@
</button>
</mat-chip-row>
</ng-container>
<mat-chip-row class="filter-chip-clear-all">
<button
type="button"
(click)="clearAllFilters()"
(keydown.enter)="clearAllFilters()"
(keydown.space)="clearAllFilters()"
aria-label="Clear all filters"
tabindex="0"
class="clear-button"
mat-button>
Clear all filters
</button>
</mat-chip-row>
<div
tabindex="0"
mat-chip-row
role="row"
(click)="clearAllFilters()"
(keydown.enter)="clearAllFilters()"
(keydown.space)="clearAllFilters()"
aria-label="Clear all filters"
class="clear-button">
<div class="clear-button-label" [tabIndex]="0">Clear all filters</div>
</div>
</mat-chip-set>
33 changes: 33 additions & 0 deletions modules/ui/src/app/pages/reports/components/filter-chips/filter-chips.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,43 @@
}
}

.clear-button:has(.clear-button-label:focus),
.clear-button.cdk-keyboard-focused {
outline: colors.$black solid 2px;
}

.clear-button-label:focus {
border: none;
}

.clear-button {
height: var(--mdc-text-button-container-height);
border-radius: var(--mdc-text-button-container-shape);
margin: 0 0 0 8px !important;
border: none;
display: flex;
align-items: center;
justify-content: center;
}

.clear-button .clear-button-label {
color: colors.$primary !important;
border: none;
outline: none;
}

.clear-button ::ng-deep .mat-focus-indicator {
display: none;
}

.clear-button
::ng-deep
.mdc-evolution-chip__action--primary:not(
.mdc-evolution-chip__action--presentational
):not(.mdc-ripple-upgraded):focus::before {
border: none;
}

.filter-chip .filter-chip-remove {
margin: 0 8px;
padding-left: 0;
Expand Down
Loading