Skip to content

Update DNS from DHCP test description #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 4 commits into from
Mar 26, 2025
Merged

Update DNS from DHCP test description #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82cf482
Update DNS test description
jboddey Mar 25, 2025
72f092e
Fix pylint issue
jboddey Mar 25, 2025
a8d9699
Update Jinja2 version
jboddey Mar 25, 2025
be06aad
fix unit test
Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ paho-mqtt==2.1.0
APScheduler==3.10.4

# Requirements for reports generation
Jinja2==3.1.5
Jinja2==3.1.6
beautifulsoup4==4.12.3
2 changes: 1 addition & 1 deletion modules/test/base/python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ grpcio-tools==1.67.1
netifaces==0.11.0

# Requirements for reports generation
Jinja2==3.1.5
Jinja2==3.1.6
6 changes: 4 additions & 2 deletions modules/test/dns/python/src/dns_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,10 @@ def _dns_network_from_dhcp(self):
LOGGER.info('DNS traffic detected only to configured DHCP DNS server')
description = 'DNS traffic detected only to DHCP provided server'
else:
LOGGER.info('No DNS traffic detected from the device')
description = 'No DNS traffic detected from the device'
LOGGER.info(
'No DNS traffic detected from the device to the DHCP DNS server')
description = '' \
'No DNS traffic detected from the device to the DHCP DNS server'
return 'Informational', description

def _dns_network_hostname_resolution(self):
Expand Down
3 changes: 2 additions & 1 deletion testing/unit/dns/dns_module_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def dns_no_dns_traffic_test(self):
result = dns_module.dns_network_from_dhcp()

# Assign the expected test result
description = 'No DNS traffic detected from the device'
description =''\
'No DNS traffic detected from the device to the DHCP DNS server'
expected_result = ('Informational', description)

# Assert that the actual result matches the expected result.
Expand Down
Loading