Skip to content

Report download fails when .zip file is large #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Mar 12, 2025
Merged

Report download fails when .zip file is large #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions modules/ui/src/app/interceptors/error.interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ import {
} from 'rxjs';
import { NotificationService } from '../services/notification.service';

import { SYSTEM_STOP } from '../services/test-run.service';
import { SYSTEM_STOP, EXPORT } from '../services/test-run.service';
import { finalize } from 'rxjs/operators';

const DEFAULT_TIMEOUT_MS = 5000;
const SYSTEM_STOP_TIMEOUT_MS = 60 * 1000;
const EXPORT_ZIP_TIMEOUT_MS = 60 * 1000;

@Injectable()
export class ErrorInterceptor implements HttpInterceptor {
Expand All @@ -45,10 +46,13 @@ export class ErrorInterceptor implements HttpInterceptor {
next: HttpHandler,
timeoutMs = DEFAULT_TIMEOUT_MS
): Observable<HttpEvent<unknown>> {
const timeoutValue =
request.url.includes(SYSTEM_STOP) || this.isTestrunStop
? SYSTEM_STOP_TIMEOUT_MS
: timeoutMs;
let timeoutValue = timeoutMs;
if (request.url.includes(SYSTEM_STOP) || this.isTestrunStop) {
timeoutValue = SYSTEM_STOP_TIMEOUT_MS;
}
if (request.url.includes(EXPORT)) {
timeoutValue = EXPORT_ZIP_TIMEOUT_MS;
}
if (request.url.includes(SYSTEM_STOP)) {
this.isTestrunStop = true;
}
Expand Down
1 change: 1 addition & 0 deletions modules/ui/src/app/services/test-run.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {

const API_URL = `http://${window.location.hostname}:8000`;
export const SYSTEM_STOP = '/system/stop';
export const EXPORT = '/export';

export const UNAVAILABLE_VERSION = {
installed_version: 'v?.?',
Expand Down
Loading