Refactor FE to use BE endpoint to get the links for the report #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if "export" is missing
OlgaMardvilko
requested changes
Mar 3, 2025
Collaborator
OlgaMardvilko
left a comment
OlgaMardvilko
left a comment
There was a problem hiding this comment.
Should we make the export field to have the dynamic API URL (the same as report field)?
The code is here: https://github.com/google/testrun/blob/dev/modules/ui/src/app/services/test-run.service.ts#L60
OlgaMardvilko
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use field "export" for zip download, or make url from "report" field if "export" is missing
Video after changes. Please note that mocks are used, so the link is not actually working
http://screencast/cast/NDg0Mzc5OTYxOTU2NzYxNnw5Yzk5NWI3OC1lOA