Skip to content

Stop testing #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Feb 20, 2025
Merged

Stop testing #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/ui/src/app/components/simple-dialog/simple-dialog.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
}

.simple-dialog-title {
font-size: 18px;
line-height: 24px;
@include mixins.headline-small();
padding: 0;
text-align: center;
color: colors.$on-surface;
Expand Down
4 changes: 3 additions & 1 deletion modules/ui/src/app/pages/testrun/testrun.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@
(click)="openStopTestrunDialog(vm.systemStatus)"
class="stop-button"
aria-label="Stop testrun"
color="warn"
mat-flat-button>
<mat-icon fontSet="material-symbols-outlined" class="filled">
cancel
</mat-icon>
Stop
</button>
</ng-container>
Expand Down
23 changes: 17 additions & 6 deletions modules/ui/src/app/pages/testrun/testrun.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,22 @@
}

.stop-button {
// styles to be updated
position: absolute;
right: 24px;
bottom: 24px;
right: 40px;
bottom: 32px;
background-color: colors.$error;
padding: 26px;
border-radius: variables.$corner-large;
font-weight: 400;
font-size: 22px;
line-height: 28px;
height: 80px;
}

.stop-button {
letter-spacing: 0.25px;
padding: 0 24px;
.stop-button mat-icon {
font-size: 28px;
width: 28px;
height: 28px;
}

.progress-table {
Expand All @@ -161,3 +168,7 @@
position: relative;
overflow-y: hidden;
}

::ng-deep .stop-testrun app-simple-dialog {
width: 329px;
}
3 changes: 2 additions & 1 deletion modules/ui/src/app/pages/testrun/testrun.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,12 @@ export class TestrunComponent implements OnInit, OnDestroy {
title: `Stop testrun ${this.getTestRunName(systemStatus)}?`,
content:
'Are you sure you would like to stop testrun without a report generation?',
confirmName: 'Stop',
},
autoFocus: true,
hasBackdrop: true,
disableClose: true,
panelClass: 'simple-dialog',
panelClass: ['simple-dialog', 'stop-testrun'],
});

dialogRef
Expand Down
2 changes: 0 additions & 2 deletions modules/ui/src/app/pages/testrun/testrun.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import {
TestsData,
TestsResponse,
} from '../../model/testrun-status';
import { FocusManagerService } from '../../services/focus-manager.service';
import { LoaderService } from '../../services/loader.service';
import { TestModule } from '../../model/device';

Expand All @@ -56,7 +55,6 @@ export interface TestrunComponentState {
@Injectable()
export class TestrunStore extends ComponentStore<TestrunComponentState> {
private store = inject<Store<AppState>>(Store);
private readonly focusManagerService = inject(FocusManagerService);
private readonly loaderService = inject(LoaderService);

private dataSource$ = this.select(state => state.dataSource);
Expand Down
Loading