Skip to content

[GM3] The icon for warning callouts differs from the icons of other callouts #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Jan 2, 2025
Merged

[GM3] The icon for warning callouts differs from the icons of other callouts #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/ui/src/app/components/callout/callout.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
<mat-icon
*ngIf="type() !== CalloutType.InfoPilot"
class="callout-icon"
fontSet="material-icons-outlined"
color="primary">
fontSet="material-symbols-outlined">
{{ type() }}
</mat-icon>
<span
Expand Down
13 changes: 6 additions & 7 deletions modules/ui/src/app/components/callout/callout.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,30 +33,29 @@
}

.check_circle {
border-color: colors.$on-tertiary-container;
color: colors.$on-tertiary-container;
background-color: rgba(20, 108, 46, 0.1);
}

.info {
border-color: colors.$primary;
color: colors.$primary;
background-color: rgba(127, 207, 255, 0.16);
}

.error,
.error_outline {
border-color: colors.$on-error-container;
.error {
color: colors.$on-error-container;
background-color: rgba(179, 38, 30, 0.1);
}

.warning_amber {
border-color: colors.$orange-60;
.warning {
color: colors.$orange-40;
background-color: colors.$orange-98;
}

.warning .callout-border {
color: colors.$orange-60;
}

.callout-container {
position: relative;
overflow: hidden;
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
align-items: start !important;

&.check_circle,
&.warning_amber {
&.warning {
padding-top: 16px;
}
}
Expand Down
3 changes: 1 addition & 2 deletions modules/ui/src/app/model/callout-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export enum CalloutType {
Info = 'info',
InfoPilot = 'info pilot',
Check = 'check_circle',
Warning = 'warning_amber',
Warning = 'warning',
Error = 'error',
ErrorOutline = 'error_outline',
}
2 changes: 1 addition & 1 deletion modules/ui/src/app/pages/general-settings/general-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
-->
<div class="setting-drawer-content" *ngIf="viewModel$ | async as vm">
<app-callout
[type]="CalloutType.ErrorOutline"
[type]="CalloutType.Error"
*ngIf="settingsDisable"
action="Go to Testing tab"
(onAction)="navigateToRuntime()">
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"></ng-container>
</mat-expansion-panel-header>
<div class="expansion-panel-content cel-description">
<app-callout [type]="CalloutType.ErrorOutline">
<app-callout [type]="CalloutType.Error">
Steps to resolve
<ul class="cel-description-list">
<li *ngFor="let point of item.recommendations">{{ point }}</li>
Expand Down
Loading