Jinja ntp report #1016
Merged
Jinja ntp report #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboddey
reviewed
Dec 16, 2024
| current_size += 40 + h1_padding | ||
| # Calculating the height of paired tables | ||
| elif (el.name == 'div' | ||
| elif (el.name == 'div' and el.has_attr('style') |
Contributor
There was a problem hiding this comment.
Can you add an ID to the element and not reference it by style attr?
Collaborator
Author
There was a problem hiding this comment.
Can you add an ID to the element and not reference it by style attr?
Done
|
|
||
| else: | ||
| LOGGER.debug(f'Removed unrecognised question: {question["question"]}') | ||
| LOGGER.debug(f'Removed unrecognised question: {question["question"]}') # pylint: disable=W1405 |
Contributor
There was a problem hiding this comment.
Is the pylint disable necessary? We were never notified of a pylint issue before.
Collaborator
Author
There was a problem hiding this comment.
I saw this error when running pylint.
OlgaMardvilko
approved these changes
Dec 17, 2024
Collaborator
OlgaMardvilko
left a comment
OlgaMardvilko
left a comment
There was a problem hiding this comment.
The styles looks good to me, exactly the same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report examples:
report.pdf
(rename pdf to html after download)
report.html.pdf