Fix: adminURL from base data breaks with existing URL query args#12166
Merged
Fix: adminURL from base data breaks with existing URL query args#12166
adminURL from base data breaks with existing URL query args#12166Conversation
|
Storybook is ready:
|
|
Size Change: +125 B (+0.01%) Total Size: 2.28 MB ℹ️ View Unchanged
|
|
Build files for 10e6d8d have been deleted. |
Collaborator
Author
|
Thank you @hussain-t for reviewing the PR, I've made the changes as per the suggestions in tests. Assigning it to you for another pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
adminURLfrom base data breaks with existing URL query args #11115Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist