Skip to content

Fix log tag to use TAG constant #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helpingstar wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix log tag to use TAG constant #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0f29c
Fix log tag to use TAG constant
helpingstar Nov 6, 2025
c3bc036
Merge branch 'main' into fix-typo
temcguir Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/src/main/java/com/google/jetpackcamera/ui/components/capture/CaptureScreenComponents.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ fun PreviewDisplay(
with(coordinateTransformer) {
val surfaceCoords = it.transform()
Log.d(
"TAG",
TAG,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the change to use the TAG constant is an improvement for consistency, the presence of this Log.d statement itself should be scrutinized 1. The repository's guidelines suggest that Log.d calls are often remnants of debugging and should be removed before merging unless they provide essential, long-term value. Please consider if this log statement is necessary for the long-term operation of the application.

Style Guide References

Footnotes

  1. Scrutinize Debug Logs: Question the use of Log.d, Log.v, and especially println(). These are often remnants of debugging and should be removed before merging unless they provide essential, long-term value. ↩

"onTapToFocus: " +
"input{$it} -> surface{$surfaceCoords}"
)
Comment on lines 471 to 475
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you're fixing the log tag, there's an opportunity to improve the log message itself. The current string concatenation will not interpolate the variables it and surfaceCoords, which means the log will not contain the expected values. Using a Kotlin template string will fix this bug and make the code more concise and readable.1

                                        Log.d(
                                            TAG,
                                            "onTapToFocus: input{$it} -> surface{$surfaceCoords}"
                                        )

Style Guide References

Footnotes

  1. The style guide recommends simplifying complex logic into more concise and readable idiomatic expressions. Using a template string instead of string concatenation is a good example of this. ↩

Expand Down
Loading