Skip to content

Internal #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Internal #1224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion grain/_src/python/dataset/transformations/prefetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import functools
from multiprocessing import queues
import queue
import sys
import threading
import typing
from typing import Any, Optional, Protocol, TypeVar
Expand Down Expand Up @@ -584,7 +585,12 @@ def _stop_prefetch(self):
# Remove entries from the buffer to unblock the producer, so that it checks
# producer_running.is_set() and exits.
self._clear_buffer()
self._prefetch_thread.join()
if not sys.is_finalizing():
# Joining the worker thread is not necessary when the Python interpreter
# is shutting down. Attempting to join can lead to hanging in Python
# 3.13 as daemon threads can hang during interpreter shutdown. See
# https://github.com/python/cpython/issues/123940#issuecomment-2976446309
self._prefetch_thread.join()
self._prefetch_thread = None
# Clear the buffer again in case the prefetch loop added more elements on
# exit.
Expand Down