Use Temurin over Zulu. #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_813738660
branch
from
45dd445 to
a3c957b
Compare
And, for EscapeVelocity and Inject-Common, bump our newest testing JDK from 15 to 25. A bump would probably have been a good idea years ago, but now it's forced by the fact that Temurin doesn't appear to provide a JDK 15, at least nowadays. The change to JDK 25 sometimes has fallout: - We'll want to update any branch-protection rules that require status checks, since the name of the check will change (because it contains the version number). However, I don't see any [for EscapeVelocity](https://github.com/google/escapevelocity/settings/branches) or [for Inject-Common](https://github.com/google/inject-common/settings/branches) (yay?), so there's nothing to update there. Contrast with, e.g., [Guava](https://github.com/google/guava/settings/branches). - Similarly, we need to update our _Copybara_ config for the update to the name of the status check. Sadly, changes do not take effect until after submission (b/360096677), so I'll ultimately have to set `SKIP_COPYBARA` after manually verifying that all CI jobs passed. - And of course different Java versions can be stricter about different things, perhaps especially now that we've enabled things like `maven-javadoc-plugin` by default (cl/807859217). Fortunately, that does not seem to be an issue here. As for why we are switching to Temurin: We got [advice](google/guava#7492 (comment)) from @ben-manes: LTS versions of Temurin [come pre-installed](https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#Hosted-Tool-Cache). Compare cl/711746683 for Guava. RELNOTES=n/a PiperOrigin-RevId: 813848322
copybara-service
bot
force-pushed
the
test_813738660
branch
from
a3c957b to
834658e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Temurin over Zulu.
And, for EscapeVelocity and Inject-Common, bump our newest testing JDK from 15 to 25. A bump would probably have been a good idea years ago, but now it's forced by the fact that Temurin doesn't appear to provide a JDK 15, at least nowadays.
The change to JDK 25 sometimes has fallout:
SKIP_COPYBARAafter manually verifying that all CI jobs passed.maven-javadoc-pluginby default (cl/807859217). We'll see if any of that comesup here.As for why we are switching to Temurin: We got advice from @ben-manes: LTS versions of Temurin come pre-installed.
Compare cl/711746683 for Guava.
RELNOTES=n/a