Skip to content

Pin doc deps to lower versions#5222

Open
samanklesaria wants to merge 1 commit intogoogle:mainfrom
samanklesaria:doctest_check
Open

Pin doc deps to lower versions#5222
samanklesaria wants to merge 1 commit intogoogle:mainfrom
samanklesaria:doctest_check

Conversation

@samanklesaria
Copy link
Collaborator

This PR attempts to fix the doctests that have been failing lately by pinning ipython.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samanklesaria, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses recent failures in doctests by introducing a specific version constraint for the ipython package. By pinning ipython to version 9.9.0, the PR aims to stabilize the documentation build process and ensure the reliability of automated tests.

Highlights

  • Dependency Pinning: The ipython package has been explicitly pinned to version 9.9.0 within the docs dependency group in pyproject.toml. This action is intended to resolve recent failures observed in doctests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pyproject.toml
    • Added ipython==9.9.0 to the docs dependency list to mitigate doctest failures.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to fix failing doctests by pinning the ipython version. However, the specified version 9.9.0 is not a valid version for ipython and will cause dependency installation to fail. I have provided a critical review comment with a suggestion to use a valid version and to add a comment explaining the pin, which is good practice.

@samanklesaria
Copy link
Collaborator Author

Found something that works! Now time for a binary search: let's remove half of these pins and see what happens.

@samanklesaria samanklesaria changed the title Pin ipython to lower version Pin doc deps to lower versions Feb 4, 2026
@samanklesaria
Copy link
Collaborator Author

Looks like tqdm was the culprit.

@samanklesaria samanklesaria marked this pull request as ready for review February 4, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant