added new FCU and VAV types #1656
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shambersafai
left a comment
shambersafai
left a comment
There was a problem hiding this comment.
Some small cleanup. Please sign the CLA as well.
.gitignore
Outdated
| yarn.lock | ||
| venv/ | ||
| tooling/ | ||
| tooling/ |
There was a problem hiding this comment.
please remove this trailing space
|
|
||
| VAV_SD_DSP_CO2C_COM_ZHM: | ||
| guid: "a941d668-9c2f-4519-ad77-635a93f1a847" | ||
| description: "CO2 control VAV wiht CO monitoring and humidity monitoring." |
|
|
||
| VAV_SD_DSP_CO2M_COM_ZHM: | ||
| guid: "ce2aef8e-367f-4ab6-8603-56ddc787f0a9" | ||
| description: "VAV with zone CO2 monitoring CO monitoring and humidity monitoring." |
There was a problem hiding this comment.
nit: add comma after "CO2 monitoring"
|
|
||
| VAV_SD_DSP_HWDC_CO2C_DFVSC_COM_ZHM: | ||
| guid: "7d6dad5c-31cb-4dc9-887c-7eba3709bb61" | ||
| description: "Single duct fan powered VAV with reheat and CO2 control CO monitoring and humidity monitoring." |
There was a problem hiding this comment.
add a comma after "control"
|
|
||
| VAV_SD_DSP_HWDC_CO2C_DFSS_DFVSC_COM_ZHM: | ||
| guid: "86f64755-4de7-466c-a14a-6408ada66da0" | ||
| description: "Single duct fan powered VAV with reheat and CO2 control CO and humidity monitoring." |
There was a problem hiding this comment.
add a comma after "control"
|
@shambersafai - Comments should be updated. Thanks |
| - DFSS | ||
| - DFVSC | ||
|
|
||
| VAV_SD_DSP_HWDC_CO2C_DFSS_DFVSC_COM_ZHM: |
There was a problem hiding this comment.
this one can be removed, the one below is conceptually the same
4 participants
No description provided.