Skip to content

Nullability: add more tests for struct initialization and reorganize existing test files. #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 5, 2026
+360 −193
Merged

Nullability: add more tests for struct initialization and reorganize existing test files. #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/llvm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _llvm_loader_repository(repository_ctx):
executable = False,
)

LLVM_COMMIT_SHA = "f5dab90875c4435890a19410fcb4bcd8a96357b2"
LLVM_COMMIT_SHA = "125948a058dcd89b7fe377872a5fc1a7f9d34e70"

def llvm_loader_repository_dependencies():
# This *declares* the dependency, but it won't actually be *downloaded* unless it's used.
Expand Down
148 changes: 79 additions & 69 deletions nullability/test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,31 @@ sh_test(
data = [":nullability_test"],
)

cc_test(
name = "arrays",
srcs = ["arrays.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
cc_embed_data(
name = "test_headers",
srcs = [
"nullability_annotations.h",
"nullability_test.h",
"check.h",
"check_diagnostics_preamble.h",
"new",
"memory",
"optional",
"type_traits",
"utility",
],
outs = [
"test_headers.cc",
"test_headers.h",
"test_headers.o",
],
embedopts = ["--namespace=clang::tidy::nullability"],
visibility = ["//nullability:__subpackages__"],
)

cc_test(
name = "aliases",
srcs = ["aliases.cc"],
name = "arrays",
srcs = ["arrays.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
Expand Down Expand Up @@ -142,6 +154,16 @@ nullability_test(
srcs = ["comparisons.cc"],
)

cc_test(
name = "consistent_annotations",
srcs = ["consistent_annotations.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

cc_test(
name = "constructors",
srcs = ["constructors.cc"],
Expand Down Expand Up @@ -253,16 +275,6 @@ nullability_test(
srcs = ["initialization.cc"],
)

cc_test(
name = "initialization_diagnosis",
srcs = ["initialization_diagnosis.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

nullability_test(
name = "join",
srcs = ["join.cc"],
Expand All @@ -279,6 +291,16 @@ cc_test(
],
)

cc_test(
name = "nested",
srcs = ["nested.cc"],
deps = [
":check_diagnostics",
"@llvm-project//clang:basic",
"@llvm-project//third-party/unittest:gtest",
],
)

cc_test(
name = "operator_new",
srcs = ["operator_new.cc"],
Expand Down Expand Up @@ -324,6 +346,26 @@ cc_test(
],
)

nullability_test(
name = "pragma",
srcs = [
"pragma.cc",
"pragma_none.h",
"pragma_nonnull.h",
"pragma_support.h",
],
)

cc_test(
name = "pragma_diagnosis",
srcs = ["pragma_diagnosis.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

nullability_test(
name = "resugaring",
srcs = ["resugaring.cc"],
Expand Down Expand Up @@ -354,6 +396,16 @@ cc_test(
],
)

cc_test(
name = "struct_initialization",
srcs = ["struct_initialization.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

nullability_test(
name = "symbolic_nullability",
srcs = ["symbolic_nullability.cc"],
Expand Down Expand Up @@ -389,14 +441,9 @@ cc_test(
],
)

nullability_test(
name = "types",
srcs = ["types.cc"],
)

cc_test(
name = "variance",
srcs = ["variance.cc"],
name = "type_aliases",
srcs = ["type_aliases.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
Expand All @@ -405,63 +452,26 @@ cc_test(
)

nullability_test(
name = "pragma",
srcs = [
"pragma.cc",
"pragma_none.h",
"pragma_nonnull.h",
"pragma_support.h",
],
name = "types",
srcs = ["types.cc"],
)

cc_test(
name = "pragma_diagnosis",
srcs = ["pragma_diagnosis.cc"],
name = "variable_aliasing",
srcs = ["variable_aliasing.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

cc_embed_data(
name = "test_headers",
srcs = [
"nullability_annotations.h",
"nullability_test.h",
"check.h",
"check_diagnostics_preamble.h",
"new",
"memory",
"optional",
"type_traits",
"utility",
],
outs = [
"test_headers.cc",
"test_headers.h",
"test_headers.o",
],
embedopts = ["--namespace=clang::tidy::nullability"],
visibility = ["//nullability:__subpackages__"],
)

cc_test(
name = "consistent_annotations",
srcs = ["consistent_annotations.cc"],
name = "variance",
srcs = ["variance.cc"],
deps = [
":check_diagnostics",
"@llvm-project//third-party/unittest:gtest",
"@llvm-project//third-party/unittest:gtest_main",
],
)

cc_test(
name = "nested",
srcs = ["nested.cc"],
deps = [
":check_diagnostics",
"@llvm-project//clang:basic",
"@llvm-project//third-party/unittest:gtest",
],
)
123 changes: 0 additions & 123 deletions nullability/test/initialization_diagnosis.cc
View file
Open in desktop

This file was deleted.

Loading