-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: fix typos and grammar in unsafe deep dive pages #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix grammar, spelling, and capitalization across the Unsafe Rust deep dive chapters. Ran `dprint fmt`.
src/unsafe-deep-dive/pinning/self-referential-buffer/rust-pin.md
Outdated
Show resolved
Hide resolved
| older that 1.87. | ||
| older than 1.87. | ||
|
|
||
| For those people who do not, tell them that we'll resolve that in the break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These notes should be improved my making them actionable:
- please don't mske a script (the instructor won't have time to read it and should certainly not read from the slides)
- add the necessary information to expand on the slides. Don't leave the actual help out, tell people who read this at home to run
rustupin such-and-such a way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really for @timClicks to fix, not you @gribozavr.
mgeisler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @gribozavr for this! Your attention to detail is great. Even small things like finishing the lost items with a full stop makes things much more consistent.
Co-authored-by: Martin Geisler <martin@geisler.net>
Fix grammar, spelling, and capitalization across the Unsafe Rust deep
dive chapters. Ran
dprint fmt.