This repository was archived by the owner on Nov 14, 2023. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables multi-file input mode, similar to what dssim has. Sample use:
I tried to make the change in a way so that the diff is less intrusive. If you find that the multi-file mode is useful for butteraugli and want it refactored differently, let me know, and I'll update the PR.
The issues with the change:
isMultiFileModetries to avoid any possible issues.ProcessFilepossibly adds alpha torgb1, so,image1andimage2could be rgb24, butimage3could be rgba, which would changergb1to rgba.In any case, it was quite inconvenient to constantly run butteraugli with different filenames that I constantly needed to compare that I find this option to be a must-have :)