Fast-forward cpu_features for updated cmake #590
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu_features is 4 years old and has a CMake minimum requirement of 3.0. Since CMake 4.0 has declared anything below 3.10 to be deprecated, users with up-to-date CMake installations will get an error during configuration. While there is a workaround, it's still annoying. The lastest cpu_features has a CMake mininum requirement of 3.13. Fast-forwarding cpu_features to latest, therefore, solves this inconvenience. Fixes google#564
footballhead
force-pushed
the
upgrade_cpu_features
branch
from
2b51848 to
bb6cfb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpu_features is 4 years old and has a CMake minimum requirement of 3.0. Since CMake 4.0 has declared anything below 3.10 to be deprecated, users with up-to-date CMake installations will get an error during configuration. While there is a workaround, it's still annoying.
The lastest cpu_features has a CMake mininum requirement of 3.13. Fast-forwarding cpu_features to latest, therefore, solves this inconvenience.
Fixes #564