Use abseil logging instead of libbase's #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Databean
approved these changes
Dec 31, 2025
This change makes no sense by itself, but it reduces noise in follow up changes.
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
The main differences come from abseil not having a single logger object and not providing access to the already configured log sinks.
This change mostly replaces the included headers and turns LOG(DEBUG) and LOG(VERBOSE) into VLOG(0) and VLOG(1) respectively.
This variable was instructing subprocesses to log at verbose level by default, but it was then overriden in most cases by setting the stderr logger to info and the file logger to verbose.
It was logging at INFO level only to fetch.log. Removes handling of the verbosity flag at the fetch command handler level and leaves it at cvd level only.
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Jan 2, 2026
This was missed in google#1955 . Bug: b/321795781
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Jan 3, 2026
This was missed in google#1955 . Changing the log header additionally caused a new unrelated error, which is also fixed: ``` In file included from allocd/alloc_utils.cpp:16: allocd/alloc_utils.h:28:10: error: module //allocd:alloc_utils does not depend on a module exporting 'cuttlefish/common/libs/fs/shared_fd.h' 28 | #include "cuttlefish/common/libs/fs/shared_fd.h" | ^ 1 error generated. ``` Bug: b/321795781
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2026
This was missed in #1955 . Changing the log header additionally caused a new unrelated error, which is also fixed: ``` In file included from allocd/alloc_utils.cpp:16: allocd/alloc_utils.h:28:10: error: module //allocd:alloc_utils does not depend on a module exporting 'cuttlefish/common/libs/fs/shared_fd.h' 28 | #include "cuttlefish/common/libs/fs/shared_fd.h" | ^ 1 error generated. ``` Bug: b/321795781
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Jan 6, 2026
Following google#1955 Bug: b/321795781
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
Following #1955 Bug: b/321795781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: b/321795781