Adding shader long vector feature #1100
Open
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove VK_ACCESS_HOST_READ_BIT and VK_ACCESS_HOST_WRITE_BIT from kMemoryBarrierForAll as these flags are only valid with VK_PIPELINE_STAGE_HOST_BIT, not VK_PIPELINE_STAGE_ALL_COMMANDS_BIT
Adds support for requesting the shader long vector to be used.
dj2
approved these changes
Jan 19, 2026
Collaborator
|
This looks good to me, need to see what the bots say. Is it possible to add an amber example script into the repo to show the functionality? |
Contributor
Author
|
Hi Dan, I prepared this pull request because I’m helping to get the new CTS tests for VK_EXT_shader_long_vector passing amber verification in our CI. I upcoming CTS tests there already is an amber file that Jeff Bolz @jeffbolznv wrote for testing purposes: Does that count as an example? or after adding each new feature to amber you'll also like to have some kind of internal sample? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for requesting the shader long vector to be used
DEPS update to alight witch v1.4.337