Add zero init memory feature to amber #1099
Merged
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
approved these changes
Jan 19, 2026
Collaborator
dj2
left a comment
dj2
left a comment
There was a problem hiding this comment.
LGTM. Is it possible to add an amberscript example?
| "VulkanMemoryModelFeatures.vulkanMemoryModelDeviceScope"; | ||
|
|
||
| const char kZeroInitializeWorkgroupMemory[] = | ||
| "ZeroInitializeWorkgroupMemoryFeatures." |
Collaborator
There was a problem hiding this comment.
Did this split due to line wrapping?
Collaborator
Author
There was a problem hiding this comment.
Ooops didnt see this before the merge. I will address this issue.
| features_.zero_initialize_workgroup_memory_features, | ||
| // NOLINTNEXTLINE(whitespace/line_length) | ||
| VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ZERO_INITIALIZE_WORKGROUP_MEMORY_FEATURES_KHR, | ||
| // NOLINTNEXTLINE(whitespace/line_length) |
Collaborator
There was a problem hiding this comment.
This one shouldn't be needed? Like, line 1317 is longer ...
Collaborator
Author
There was a problem hiding this comment.
Minor but I will also address
Collaborator
Author
|
I will address the minor issues and add the amberscript example test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this with an amber script generated from dawn
You need to add these to your script to enabled
DEVICE_EXTENSION VK_KHR_zero_initialize_workgroup_memory
DEVICE_FEATURE ZeroInitializeWorkgroupMemoryFeatures.shaderZeroInitializeWorkgroupMemory