Fix vhost user backend #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vhost-user protocol requires 64-bit device features, but the virtio spec allows 128. This commit truncates features to 64 bits before sending, fixing a bug where all 128 bits were sent, causing feature negotiation to fail. Fixes: 128153e ("fix(virtio): extend virtio feature to 128 bits") Signed-off-by: Changyuan Lyu <changyuanl@google.com>
A VirtIO device generally needs exclusive access to specific resources on the host. Creating multiple devices from the same config to serve multiple VMs simultaneously could lead to resource contention. Especially, commit de79b5f made device creation ahead of connection acceptance, and failed virtio-net devices, because when 1 virtio-net device is running, another virtio-net device is created, and the latter opens the same tap again, interfering with the first device's IO. Fixes: de79b5f ("fix(vu): create devices before accepting connections") Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Pull Request Test Coverage Report for Build 20670071517Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.