Update nrf52840_dongle.md

[icicle1133]

Fixes closed issue #739

Even with a new board, no other software installed onto it, i ran into the same issues yet again without running --erase_storage first. This commit fixes that in the .md for nordic dongles (NOT DK/Development boards.)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @icicle1133, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recurring issue with flashing firmware onto nRF52840 dongles by updating the relevant documentation. It introduces a critical step to erase storage prior to flashing, which has been found to resolve problems even on new boards. This change aims to provide clearer and more robust instructions for users, preventing common setup frustrations.

Highlights

• Documentation Update: The nrf52840_dongle.md documentation has been updated to improve the firmware flashing process.
• Erase Storage Recommendation: A new, highly recommended step to use --erase_storage before flashing firmware has been added to prevent common issues.
• Command Clarity: The --erase_storage command is now presented as a distinct, recommended first step, followed by the firmware flashing command.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the flashing instructions for the nRF52840 dongle to include a necessary step for erasing storage, which is a valuable addition to prevent potential flashing issues for users. My review includes a couple of suggestions to enhance the clarity and correctness of the new instructions. Specifically, I've recommended making the instruction to erase storage more direct and correcting the example command by adding the required programmer argument to ensure it works as intended for the DFU flashing method.

[gemini-code-assist]

The phrasing "It is highly recommended" might be too weak. Based on your PR description and the general install.md guide, erasing storage seems to be a required step for new boards or boards that have been used for other purposes. To avoid user confusion and flashing issues, it would be better to make this instruction more direct.

Suggested change

	It is highly recommended you use --erase_storage first, especially if you have installed any other software onto your dongle.
	To prevent potential issues, you must first erase the dongle's storage. This is especially important for new boards or if other software has been installed on it.

[gemini-code-assist]

The command to flash the erase_storage application is missing the --programmer=nordicdfu argument. Without it, the deploy.py script defaults to using jlink as the programmer. This is incorrect for the DFU flashing method described in this document and will cause an error for users who don't have a J-Link debugger.

Suggested change

	./deploy.py --board=nrf52840_dongle_dfu --erase_storage
	./deploy.py --board=nrf52840_dongle_dfu --erase_storage --programmer=nordicdfu

[kaczmarczyck]

The fact that people need erase_storage is not specific to the dongle. Therefore, in #744 , I added an explanation in the general install doc. Is the reason you want it in the dongle setup that the dongle doc was you landing page? Would it make sense to refer back to the install.md from all boards to make sure people don't miss it?