hps/linker.ld: Fix large data address #404
Conversation
Fixes large data in address space. This makes loading programs onto proto2 faster since these data structures do not need to be updated if they have not changed. Signed-off-by: Alan Green <avg@google.com>
| LDSCRIPTS := $(LDSCRIPT) $(GEN_LD_DIR)/output_format.ld $(GEN_LD_DIR)/regions.ld | ||
|
|
||
| SRC_DIR := $(BUILD_DIR)/src | ||
| SRC_DIR := src |
There was a problem hiding this comment.
We are in $(BUILD_DIR), right? What's the motivation for this change?
There was a problem hiding this comment.
Before this change, to identify a file by path, the linker script would need to include the absolute path name.
|
I had forgotten about #323 ! Thank you for pointing it out. My motivation with this change is to shorten the load time during the development cycle - it currently takes 80s to load hps_accel software onto proto2. It might also bring some consistency to run times (depending on why they vary so much) but that is not the goal here. |
I see, by having more fixed data at fixed locations, the number of blocks of flash storage that don't change and therefore don't need to be rewritten is greatly increased. |
|
Yes, that's exactly right. David has some neat MCU + host side code that
hashes SPI flash blocks and doesn't update on change, but we mostly haven't
taken advantage of it yet.
…On Fri, Jan 7, 2022 at 7:14 AM TCal ***@***.***> wrote:
My motivation with this change is to shorten the load time during the
development cycle - it currently takes 80s to load hps_accel software onto
proto2.
I see, by having more fixed data at fixed locations, the number of blocks
of flash storage that don't change and therefore don't need to be rewritten
is greatly increased.
—
Reply to this email directly, view it on GitHub
<#404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ4WAUVUQZUILWME235CPLUUXZ3XANCNFSM5LLS75WQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2 participants
Fixes large data in address space. This makes loading programs onto
proto2 faster since these data structures do not need to be updated if
they have not changed.
Signed-off-by: Alan Green avg@google.com