_total_steps assignment position bug#42
Open
MichelangeloConserva wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
_total_steps assignment position bug#42MichelangeloConserva wants to merge 1 commit intogoogle-deepmind:mainfrom
MichelangeloConserva wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
The _total_steps should be increased after the agent takes an action as in the jax implementation of this agent. For values of the sgd_period higher than one, this bugs prevents the agent from training.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _total_steps should be increased after the agent takes an action, as in the jax implementation, or during the update function call, as for DQN. If the assignment is done after computing the gradient, as in the current implementation, the agent will not be trained for values of the sgd_period values higher than one.