Extract simplego backend into standalone module#1
Open
ajroetker wants to merge 1 commit intogomlx:mainfrom
Open
Extract simplego backend into standalone module#1ajroetker wants to merge 1 commit intogomlx:mainfrom
ajroetker wants to merge 1 commit intogomlx:mainfrom
Conversation
Move the simplego backend, go-highway contrib packages, and supporting code from gomlx/gomlx and ajroetker/go-highway into a standalone github.com/gomlx/backend module. Key changes: - gomlx/: simplego backend (package simplego) with highway SIMD bridge inlined directly, removing the interface/registration indirection - pkg/matmul, pkg/nn, pkg/activation: go-highway contrib packages with rewritten inter-package imports - pkg/workerpool: consolidated worker pool merging the channel-based ParallelFor pool and mutex-based ad-hoc goroutine pool into one - pkg/packgemm: packed GEMM implementation - internal/cmd/: code generators (simplego_generator, simplego_dispatcher, alternates_generator, packgemm_generator) - Tool directives for hwygen (go-highway code generator) and goat (C-to-Go assembly tool) with ajroetker/goat fork replace - Test tolerances adjusted for always-active highway SIMD path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gomlx/gomlxand go-highway contrib packages fromajroetker/go-highwayinto a standalonegithub.com/gomlx/backendmoduleHighwayMatMulinterface,RegisterHighway(), side-effect import pattern)internal/workerspoolmutex-based pool andpkg/workerpoolchannel-based pool) into a singlepkg/workerpoolpackagego tooldirectives forhwygenandgoatwith the ajroetker/goat fork replaceModule layout
Test plan
go build ./...passesgo vet ./...passesgo test ./gomlx/...passesgo test ./pkg/...passes (matmul, nn, activation, packgemm, workerpool)go tool hwygen --helpresolves correctlygo tool goat --helpresolves correctly