fix: handle nested emphasis in triple-char closers#355
Merged
kjk merged 1 commit intogomarkdown:masterfrom Feb 17, 2026
Merged
Conversation
When input like `**bold *ital***` is parsed, the `***` closing delimiter is consumed as `**` by helperDoubleEmphasis, leaving the inner `*ital` without a closing `*`. This produces incorrect output: `<strong>bold *ital</strong>*` instead of `<strong>bold <em>ital</em></strong>`. When the closing delimiter is `***` and the content contains a trailing unclosed emphasis opener, shift the content boundary to include one extra `*` so the inner emphasis can pair correctly. The hasTrailingEmphOpener helper checks only the last `*` in the content to avoid false positives on balanced pairs like `*ital*`. Fixes gomarkdown#279
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helperDoubleEmphasisconsumes***as**, leaving the inner*unpaired. Fix shifts the content boundary to include it when the last*in content is an unmatched opener.hasTrailingEmphOpenerchecks only the last*-- checking earlier ones would flag balanced pairs incorrectly. This is a targeted fix for the**bold *ital***pattern, not a full overhaul of emphasis delimiter handling. Babelmark confirms the expected output: https://babelmark.github.io/?text=**bold+*ital***4 tests: unclosed inner emph, balanced inner (regression guard), reversed nesting, no inner star.
go test ./...passes.Fixes #279