fix: replace invalid codepoints with U+FFFD in entity parser#353
Merged
kjk merged 1 commit intogomarkdown:masterfrom Feb 17, 2026
Merged
fix: replace invalid codepoints with U+FFFD in entity parser#353kjk merged 1 commit intogomarkdown:masterfrom
kjk merged 1 commit intogomarkdown:masterfrom
Conversation
entity() emits a literal null byte for � instead of the Unicode replacement character. The CommonMark spec (section 6.2) requires U+FFFD for codepoint 0, surrogates (0xD800-0xDFFF), and values above 0x10FFFF. Check for all three invalid codepoint categories before converting to a rune.
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.
entity()converts numeric character references to runes without checking for invalid codepoints.�produces a null byte, surrogates produce invalid UTF-8, and values above 0x10FFFF are silently truncated.What changed
parser/inline.go: added a guard for the three invalid codepoint categories (0, surrogates, >0x10FFFF) that substitutes U+FFFD per CommonMark spec section 6.2inline_test.go: addedTestEntityNullByteverifying�produces U+FFFD