fix: check IndexByte return before adding in tagLength#351
Merged
kjk merged 1 commit intogomarkdown:masterfrom Feb 17, 2026
Merged
fix: check IndexByte return before adding in tagLength#351kjk merged 1 commit intogomarkdown:masterfrom
kjk merged 1 commit intogomarkdown:masterfrom
Conversation
tagLength() adds the return value of bytes.IndexByte directly to the current index. When '>' is not found, IndexByte returns -1, which decrements i instead of making it negative. The guard `if i < 0` never triggers, causing leftAngle() to silently skip characters. Store the IndexByte result in a separate variable and check it before adding to i.
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350.
tagLength()adds thebytes.IndexBytereturn value directly toi. When>is not found, the -1 return decrementsiinstead of making it negative, so theif i < 0guard never triggers. This causesleftAngle()to silently skip characters.What changed
parser/inline.go: storeIndexByteresult inj, check for -1 before adding toiinline_test.go: addedTestTagLengthUnclosedAngleverifying that unclosed angle brackets with short tag names preserve content