Skip to content

fix: skip empty citation segments after semicolon split #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjk merged 1 commit into from
Feb 17, 2026
Merged

fix: skip empty citation segments after semicolon split #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions parser/citation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ func citation(p *Parser, data []byte, offset int) (int, ast.Node) {
for _, citation := range citations {
var suffix []byte
citation = bytes.TrimSpace(citation)
if len(citation) == 0 {
continue
}
j := 0
if citation[j] != '@' {
// not a citation, drop out entirely.
Expand Down
17 changes: 17 additions & 0 deletions parser/citation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@ func TestCitationSuffix(t *testing.T) {
}
}

func TestCitationEmptySegment(t *testing.T) {
p := New()
p.extensions |= Mmark

// These inputs should not panic
inputs := [][]byte{
[]byte(`[@;]`),
[]byte(`[@ref;]`),
[]byte(`[@ref1;;@ref2]`),
}
for _, data := range inputs {
_, node := citation(p, data, 0)
// empty segments are skipped; result depends on remaining valid citations
_ = node
}
}

func TestCitationSuffixMultiple(t *testing.T) {
data := []byte(`[@?RFC1034; @!RFC1035, p. 144, more]`)

Expand Down