Skip to content
This repository was archived by the owner on Jan 7, 2023. It is now read-only.

Ibrows #90

Open
mikemeier wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ibrows #90

mikemeier wants to merge 7 commits into from

Conversation

@mikemeier
Copy link

@mikemeier mikemeier commented Aug 17, 2015

  • Reformat all /src files (PSR compatible)
  • Add DocBlocks
  • Allow to create PHPDocBlocks without wordwrap (usefull for @return statements because IDE autocomplete feature will break if the type is on a new line)
  • Will close newline in phpdoc #71

goetas
goetas reviewed Aug 17, 2015
View reviewed changes
lib/AbstractConverter.php
Copy link
Owner

@goetas goetas Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest i never liked the arrays with the dynamic spacing... (it is not convenient if you add a new entry and the entry is longer the the previously longest)
Btw it is not PSR mandatory.

I prefer the current array initialization

@goetas
Copy link
Owner

goetas commented Aug 17, 2015

Except of some minor changes, the PR looks good. Tnx!

@goetas
Copy link
Owner

goetas commented Aug 17, 2015

Most probably I need do define and publish some rules (as example the coding standard to use...).

Will try to do int in the next weeks

@goetas goetas mentioned this pull request Aug 17, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

newline in phpdoc

2 participants

@mikemeier @goetas