Skip to content

Conversation

@Faless
Copy link
Contributor

@Faless Faless commented May 26, 2025

Build dependencies using cmake.

I was nerd-sniped by the merge of #191 and #199 to try and switch to mbedTLS as the crypto library.

This should make it much easier to get ARM32/ARM64 (#260) builds on both windows and linux (I've confirmed cross-builds for linux arm32/arm64, for windows, see godotengine/webrtc-native#174 ).

I can add the CI bits as a separate commit to this PR if desired.

Comment on lines 10 to 12
# This must be kept in sync with the value in https://github.com/godotengine/godot/blob/master/platform/android/detect.py#L58.
def get_ndk_version():
return "23.2.8568313"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is no longer accurate. This one is better:
https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle#L16

And we're now on NDK r28 upstream, though I don't know how in sync the Git plugin needs to be...

Actually, we don't build this plugin for Android, so I guess this is just copied from another cross-platform repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this comes from the webrtc-native repository.

I've been wondering how we can maintain GDExtension compatibility.... what happens if we build with a different NDK version? Is targeting the lowest NDK guaranteed to work? AFAIK using a newer version results in the library failing to load.

@akien-mga
Copy link
Member

Seems good to me. If anything we're more familiar with mbedTLS and it works well for Godot, so it's a better pick IMO.

As discussed with @Calinou, we'll first make a release with the new OpenSSL PRs merged (and Godot 4.2 baseline), and then merge this PR and make another release.

So there will be a recent release with OpenSSL and Godot 4.2 to compare with in case there are any new issues related to mbedTLS.

@Faless Faless force-pushed the feat/mbedtls branch 3 times, most recently from b0cab0c to c9eb393 Compare May 28, 2025 11:22
@Faless Faless force-pushed the feat/mbedtls branch 2 times, most recently from 0bd4381 to da656d6 Compare May 29, 2025 14:19
Build dependencies using cmake
@Calinou
Copy link
Member

Calinou commented Dec 10, 2025

@Faless Can you look into rebasing this PR? The SSL certificate issue is still being run into regularly with 3.2.1, so I'd like to merge this, tag 3.3.0 and hopefully fix the issue once and for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants