InnerArray: remove generic + unsafe methods in favor of AnyArray#1506
Merged
InnerArray: remove generic + unsafe methods in favor of AnyArray#1506
InnerArray: remove generic + unsafe methods in favor of AnyArray#1506Conversation
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1506 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1357 introduced special codegen: selected builtin methods returning arrays are now unsafe, and some of them generic. The reason behind this was that methods like
Array::duplicatereturnedVarArrayper JSON declaration, but in fact the returned array is typed. This is unsound if used as-is, which is why there was anunsafeconversion for theArrayclient code.The existence of
AnyArray(andAnyDictionary) as a covariant base makes this no longer necessary: we can simply returnAnyArrayand then use a safe downcast to the correct type. This would theoretically panic (not cause UB), but as long as Godot upholds its contract, it's infallible.