Skip to content

Refresh Twitter social and update Bluesky icon #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eherman-godaddy merged 3 commits into from
Jul 22, 2025
Merged

Refresh Twitter social and update Bluesky icon #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eab979
Update twitter name/icon
eherman-godaddy Jul 22, 2025
af7d151
Update x icon, update bluesky icon
eherman-godaddy Jul 22, 2025
ea00fe1
Update unit test with new X name
eherman-godaddy Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .dev/assets/shared/images/social/bluesky.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions .dev/assets/shared/images/social/x.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 5 additions & 4 deletions .dev/tests/php/test-template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,13 +1238,14 @@ public function test_social_icons_facebook() {
}

/**
* Test the post_meta() returns proper data twitter icon data
* Test the post_meta() returns proper data x icon data
*/
public function test_social_icons_twitter() {
public function test_social_icons_x() {

set_theme_mod( 'social_icon_twitter', 'https://www.twitter.com/custom' );
// Note: X is the new name for Twitter, but the theme_mod name should remain as 'social_icon_twitter' for compatibility.
set_theme_mod( 'social_icon_twitter', 'https://www.x.com/custom' );

$this->expectOutputRegex( '/<a class="social-icons__icon" href="https:\/\/www.twitter.com\/custom" aria-label="Open Twitter in a new tab" rel="noopener noreferrer" target="_blank">/' );
$this->expectOutputRegex( '/<a class="social-icons__icon" href="https:\/\/www.x.com\/custom" aria-label="Open X in a new tab" rel="noopener noreferrer" target="_blank">/' );

Go\social_icons( [] );

Expand Down
6 changes: 3 additions & 3 deletions includes/core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,9 +1195,9 @@ function get_available_social_icons() {
'placeholder' => 'https://facebook.com/user',
),
'twitter' => array(
'label' => esc_html__( 'Twitter', 'go' ),
'icon' => get_theme_file_path( 'dist/images/social/twitter.svg' ),
'placeholder' => 'https://twitter.com/user',
'label' => esc_html__( 'X', 'go' ),
'icon' => get_theme_file_path( 'dist/images/social/x.svg' ),
'placeholder' => 'https://x.com/user',
),
'instagram' => array(
'label' => esc_html__( 'Instagram', 'go' ),
Expand Down
2 changes: 1 addition & 1 deletion languages/go.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"9a916bca2f53405524c5467058f78fde": "Footer 3",
"cf64efb396b872a492aff56944cf469b": "Footer 4",
"d85544fce402c7a2a96a48078edaf203": "Facebook",
"2491bc9c7d8731e1ae33124093bc7026": "Twitter",
"02129bb861061d1a052c592e2dc6b383": "X",
"55f015a0c5605702f913536afe70cfb0": "Instagram",
"e884c507c5198a4578a84498f7a323e2": "LinkedIn",
"f6925de5c5888c8e835efe6fe82a3982": "Xing",
Expand Down
4 changes: 2 additions & 2 deletions languages/go.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgstr ""
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"POT-Creation-Date: 2025-07-22T18:53:17+00:00\n"
"POT-Creation-Date: 2025-07-22T19:15:19+00:00\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"X-Generator: WP-CLI 2.12.0\n"
"X-Domain: go\n"
Expand Down Expand Up @@ -824,7 +824,7 @@ msgid "Facebook"
msgstr ""

#: includes/core.php:1198
msgid "Twitter"
msgid "X"
msgstr ""

#: includes/core.php:1203
Expand Down