Add timeout on metric HTTP requests #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, neither webrick or rack will timeout http requests. This means that if a request to `/metrics` or `/queue/metrics` takes longer than the `scrape_timeout`, we risk backing up requests for metrics and eventually overloading the worker. This adds rack-timeout to force the request to exit after the default timeout of 30 seconds (but it can be changed either by setting `RACK_TIMEOUT_SERVICE_TIMEOUT` to a different value or by the `--metrics-request-timeout` options flag when starting the worker).
ivgiuliani
force-pushed
the
timeout-requests
branch
from
28e4971 to
62421c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, neither webrick or rack will timeout http requests. This
means that if a request to
/metricsor/queue/metricstakes longerthan the
scrape_timeout, we risk backing up requests for metrics andeventually overloading the worker.
This adds rack-timeout to force the request to exit after the default
timeout of 30 seconds (but it can be changed either by setting
RACK_TIMEOUT_SERVICE_TIMEOUTto a different value or by the--metrics-request-timeoutoptions flag when starting the worker).