Skip to content

writer: handle imports for slice params #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enosi-rl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

writer: handle imports for slice params #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/gtrace/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ func (w *Writer) typeImports(dst []dep, t types.Type) []dep {
if p, ok := t.(*types.Pointer); ok {
return w.typeImports(dst, p.Elem())
}
if p, ok := t.(*types.Slice); ok {
return w.typeImports(dst, p.Elem())
}
n, ok := t.(*types.Named)
if !ok {
return dst
Expand Down
13 changes: 13 additions & 0 deletions test/test_imports_pointer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package test

import "github.com/gobwas/gtrace/test/internal"

//go:generate gtrace -v

//gtrace:gen
//gtrace:set shortcut
// NOTE: must compile without unused imports error.
type TracePointer struct {
OnSomethingA func(Type)
OnSomethingB func(*internal.Type)
}
68 changes: 68 additions & 0 deletions test/test_imports_pointer_gtrace.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions test/test_imports_slice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package test

import "github.com/gobwas/gtrace/test/internal"

//go:generate gtrace -v

//gtrace:gen
//gtrace:set shortcut
// NOTE: must compile without unused imports error.
type TraceArray struct {
OnSomethingA func(Type)
OnSomethingB func([]internal.Type)
}
68 changes: 68 additions & 0 deletions test/test_imports_slice_gtrace.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.