Skip to content

[harfbuzz] check advances in test suite (related to #210) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andydotxyz merged 1 commit into from
Dec 23, 2025
Merged

[harfbuzz] check advances in test suite (related to #210) #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions harfbuzz/harfbuzz_shape_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,17 @@ func (mft testInput) shape(t *testing.T, verify bool) (string, error) {
return "", err
}

// check that YAdvance is only used for vertical text
// and XAdvance for horizontal text
isHorizontal := buffer.Props.Direction.isHorizontal()
for _, pos := range buffer.Pos {
if isHorizontal {
tu.Assert(t, pos.YAdvance == 0)
} else {
tu.Assert(t, pos.XAdvance == 0)
}
}

return buffer.serialize(font, mft.format), nil
}

Expand Down