Skip to content

Improve diff file headers #36215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
silverwind wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Improve diff file headers #36215

silverwind wants to merge 11 commits into from
+43 −33

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 19, 2025 •
edited
Loading

  • reduce file name font size from 15px to 14px
  • fix labels and buttons being cut off when their size is constrained
  • change labels from monospace to sans-serif font
  • move diff stats to right and change them from sum of changes to +/-
  • change filemode to label and change text to lowercase single words to match other labels

Before

Screenshot 2025-12-20 at 18 02 15 Screenshot 2025-12-20 at 18 02 33

After

Screenshot 2025-12-20 at 18 01 25

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Dec 19, 2025
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Dec 19, 2025
@silverwind silverwind marked this pull request as draft December 19, 2025 17:48
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Dec 19, 2025
@silverwind silverwind marked this pull request as ready for review December 20, 2025 17:05
@silverwind
Merge remote-tracking branch 'origin/main' into diffhead
f013a64 
* origin/main:
  Closed milestones with no issues now show as 100% completed (go-gitea#36220)
  Show edit page confirmation dialog on tree view file change (go-gitea#36130)
  Fix regression in writing authorized principals (go-gitea#36213)
  [skip ci] Updated translations via Crowdin
  Convert locale files from ini to json format (go-gitea#35489)
@silverwind
fix, lowercase single-word all git.filemode
007e07f
@silverwind
Copy link
Member Author

silverwind commented Dec 20, 2025

This is ready, I've updated OP and cleaned up the PR comments.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2025
@lunny
Copy link
Member

lunny commented Dec 21, 2025

move diff stats to right and change them from sum of changes to +/-

Why the change is better?

@silverwind
Copy link
Member Author

silverwind commented Dec 23, 2025 •
edited
Loading

It's following GitHub's current design:

image

I think it's much more useful to see +/- instead of the current sum.

GitLab also has the +/- design, but they only show numbers:

image

Maybe later I will also implement this "5 boxes" design, but not in this PR.

@silverwind
Copy link
Member Author

silverwind commented Dec 24, 2025 •
edited
Loading

The template on pull request tabs bar now also uses templates/repo/diff/stats.tmpl. Appearance is unchanged, tooltip is added (although I find this tooltip mostly unnecessary now).

image

@silverwind
Copy link
Member Author

silverwind commented Dec 24, 2025 •
edited
Loading

One more enhancement, remove box-shadow hack.

Before: Ugly ":target" border:

Screenshot 2025-12-24 at 02 09 17

After: Clean border:

Screenshot 2025-12-24 at 02 09 38

I couldn't notice the "borders being visible behind top corners" problem, so likely this hack was obsolete anyways.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @lafriks @GiteaBot