Skip to content

Conversation

@AlekSi
Copy link

@AlekSi AlekSi commented Jul 7, 2014

Useful for long slices.

@philcluff
Copy link

Any reason this can't be merged?

@niemeyer
Copy link
Contributor

niemeyer commented Feb 9, 2015

Sorry for the very late review. I'm in the process of reorganizing my workflow to manage the firehose I've been dealing with. About the issue:

Originally the error message should only be used when the checker is incorrectly dealt with, which is not the situation here. A non-matching HasLen is simply a failed check.

That said, this is an interesting case. The usual technique of replacing the parameter value itself to better represent the check made is not ideal. We can either merge this and change the semantics of what that result means (perhaps doable), or we can improve the logging across the board for every slice or array, by mentioning its length. I'm tempted to go for the latter option.

Please let me ponder on this just a bit longer. Will get back here in the next few days.

@AlekSi
Copy link
Author

AlekSi commented Jun 27, 2015

Hit this issue again.

… or we can improve the logging across the board for every slice or array, by mentioning its length. I'm tempted to go for the latter option.

I'm all for it.

@AlekSi
Copy link
Author

AlekSi commented Apr 16, 2017

Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants