Clarify return value w/ invalid team_split_strided#161
Open
davidozog wants to merge 1 commit intogmegan:masterfrom
Open
Clarify return value w/ invalid team_split_strided#161davidozog wants to merge 1 commit intogmegan:masterfrom
davidozog wants to merge 1 commit intogmegan:masterfrom
Conversation
Signed-off-by: David M. Ozog <david.m.ozog@intel.com>
Collaborator
|
I'll pull this change into my branch from the F2F, which has a few extra fixes related to error behavior. I'll get that ready to read at the next call. This change will have to be replicated and adapted in a number of other places as well. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first change attempts to clarify what happens when
parent_teamis invalid - I find the original sentence a little difficult to parse. Is this better?I'm also unsure whether setting
new_teamtoSHMEM_TEAM_INVALIDis a "successful" creation ofnew_teamand whether the return value should be nonzero. Either way is fine with me, but in this PR I assume this case is "unsuccessful", so a nonzero value is returned.