Skip to content

Conversation

@jhollway
Copy link
Contributor

@jhollway jhollway commented Mar 19, 2025

Description

Components

  • Improved year() to be faster and work on durations
  • Improved precision()
    • precision() is now a S3 generic, dispatching to precision.mdate()
    • precision.mdate() now returns the inverse of the previous measure,
      meaning maximising precision makes more sense

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

@jhollway
Copy link
Contributor Author

precision() now a generic (necessary for next version of manydata), and measure inverted. I think this makes more sense, as one might then "maximise" precision by aiming for 1. Thoughts @henriquesposito ?

Copy link
Collaborator

@henriquesposito henriquesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@jhollway jhollway self-assigned this Mar 20, 2025
@jhollway jhollway merged commit 669bf81 into main Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants