Added way to send requests to forward proxy for enabled customer and data sources #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently our glean-proxy will make a direct connection to a data source. We want to provide a way to route these requests via forward proxy. So that the requests can be monitored by the forward proxy.
We need to set the following environment variables to make the requests go through the forward proxy:
Context:
We needed this so that the customer can host a forward proxy which can inspect all the requests going to the data sources.
Test plan:
Ran the glean-proxy server with the following environment variable
bazel run //src/main/java/com/glean/proxy:ProxyMain 8080Environment variables
For the forward proxy we just used the glean-proxy to run as forward proxy with a different port
bazel run //src/main/java/com/glean/proxy:ProxyMain 8888Environment variables
Made the following requests
curl --proxy localhost:8080 https://www.example.comcurl --proxy localhost:8080 https://www.google.comScreenshot of glean-proxy at 8080 logs

Screenshot of forward-proxy at 8888 logs

As you see only
www.google.comwent through the forward proxy andwww.example.comdoesn't have any log in the forward proxy as it is a direct connectionChange Type
Platform (Choose one if applicable)