Removing the alteration of Array.prototype with a custom function#57
Open
fidian wants to merge 1 commit intoglad:masterfrom
fidian:array-index-of
Open
Removing the alteration of Array.prototype with a custom function#57fidian wants to merge 1 commit intoglad:masterfrom fidian:array-index-of
fidian wants to merge 1 commit intoglad:masterfrom
fidian:array-index-of
Conversation
|
agree completely. I think nowadays it's common consensus that JS prototypes should not be touched by libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating over Array objects with a "for (propName in objectName)" syntax, this extra _indexOf method shows up. While not a problem for most code, I have had problems with other plugins that iterate over Arrays without checking their length.
In addition to submitting pull requests to fix that other code, I'm also trying to help avoid the problems that this plugin might have with the rest of the world.