Skip to content

Fix style parser to handle [ or ] in text without style #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrewarrow wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Fix style parser to handle [ or ] in text without style #321

andrewarrow wants to merge 29 commits into from

Conversation

@andrewarrow
Copy link

@andrewarrow andrewarrow commented Nov 9, 2022

There is a problem with using [ or ] in text. Style Parser thinks you are going to supply a (style) block after and eats some of the chars:

#311

This PR re-writes the logic to look for pairs or "](" and only processes style when needed and leaves normal [ or ] in text alone.

@andrewarrow
adding start of style_parser_test
59f7502
@andrewarrow
adding failing test for [text] and no color info after
a5730c9
@andrewarrow
good failing tests showing the problem
f047fb3
@andrewarrow
fixing one test with wrong logic
2bd947e
@andrewarrow
test to make sure current logic stays working
94288e8
@andrewarrow
very broken but just starting logic for new ParseStyles func
c4fdef9
@andrewarrow
returning a styleString
99a9b41
@andrewarrow
adding new test for PrepareStyles
4d1aaf1
@andrewarrow
testing easy case of no style
70b8f74
@andrewarrow
progress with parsing
90c992f
@andrewarrow
getting ready to link up styles
22d0058
@andrewarrow
progress with style
c77684f
@andrewarrow
clean up and better order
eaf7f8d
@andrewarrow
more cleanup of printing
f893b6f
@andrewarrow
broken but good new direction
3be455e
@andrewarrow
StyleStringPosition struct helping
4901307
@andrewarrow
better logic than split
2c85cd9
@andrewarrow
moving to new FindStylePositions as first call
291e957
@andrewarrow
index checks for test
f9eac67
@andrewarrow
clean up and new broken test but with good indexes to hit
ea81b84
@andrewarrow
TestFindStyleBlocks is working
33fef6c
@andrewarrow
start of TestBreakBlocksIntoStrings
21dc21d
@andrewarrow
logic breaking up blocks right
80c0896
@andrewarrow
cleanup and printing result in test
6cf9178
@andrewarrow
getting ready for final logic
55ae618
@andrewarrow
more cleanup and comments
29db86d
@andrewarrow
adding containsStyle func
2380572
@andrewarrow
all tests passing
ecf4951
@andrewarrow
removing printlns
a7d7cdb
@andrewarrow andrewarrow mentioned this pull request Nov 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andrewarrow