Skip to content

Upgrade React to v19.2.3 (and fix type errors in useRef hooks) #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d10c merged 9 commits into from
Dec 18, 2025
Merged

Upgrade React to v19.2.3 (and fix type errors in useRef hooks) #4237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e712e2
Initial plan
Copilot Dec 17, 2025
8ca5bfe
Merge React 19 upgrade from dependabot branch
Copilot Dec 17, 2025
40f6dab
Fix React 19 useRef type errors and eslint config
Copilot Dec 17, 2025
450e35f
Upgrade react-dom to 19.2.3 to match react version
Copilot Dec 17, 2025
ae270c8
Restore correct package versions (revert unintended downgrades from d…
Copilot Dec 17, 2025
a1a9b65
Security fix: Update glob to 11.1.0 to address command injection vuln…
Copilot Dec 17, 2025
ffac626
Upgrade React to 19.2.3 and fix useRef type errors
Copilot Dec 17, 2025
8febd66
Fix eslint config: restore .flat accessor for reactHooks.configs
Copilot Dec 17, 2025
1cae7d7
Use caret (^) prefix for React package versions
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 30 additions & 38 deletions extensions/ql-vscode/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,8 +2080,8 @@
"nanoid": "^5.0.7",
"p-queue": "^8.0.1",
"proper-lockfile": "^4.1.2",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.2.3",
"react-dom": "^19.2.3",
"semver": "^7.6.2",
"source-map": "^0.7.6",
"source-map-support": "^0.5.21",
Expand Down Expand Up @@ -2135,8 +2135,8 @@
"@types/js-yaml": "^4.0.6",
"@types/node": "22.19.*",
"@types/proper-lockfile": "^4.1.4",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@types/sarif": "^2.1.2",
"@types/semver": "^7.5.8",
"@types/stream-json": "^1.7.1",
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/model-alerts/ModelAlertsResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const ModelAlertsResults = ({
[modelAlerts.model],
);

const ref = useRef<HTMLElement>();
const ref = useRef<HTMLElement | undefined>(undefined);

useEffect(() => {
if (
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/model-editor/MethodRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export type MethodRowProps = {
export const MethodRow = (props: MethodRowProps) => {
const { method, methodCanBeModeled, revealedMethodSignature } = props;

const ref = useRef<HTMLElement>();
const ref = useRef<HTMLElement | undefined>(undefined);

useEffect(() => {
if (method.signature === revealedMethodSignature) {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/AlertTablePathNodeRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ interface Props {
pathIndex: number;
resultIndex: number;
selectedItem: undefined | ResultKey;
selectedItemRef: React.RefObject<HTMLTableRowElement>;
selectedItemRef: React.RefObject<HTMLTableRowElement | null>;
databaseUri: string;
sourceLocationPrefix: string;
run?: Run;
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/AlertTablePathRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export interface Props {
resultIndex: number;
currentPathExpanded: boolean;
selectedItem: undefined | ResultKey;
selectedItemRef: React.RefObject<HTMLTableRowElement>;
selectedItemRef: React.RefObject<HTMLTableRowElement | null>;
databaseUri: string;
sourceLocationPrefix: string;
run?: Run;
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/results/AlertTableResultRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface Props {
resultIndex: number;
expanded: Set<string>;
selectedItem: undefined | ResultKey;
selectedItemRef: React.RefObject<HTMLTableRowElement>;
selectedItemRef: React.RefObject<HTMLTableRowElement | null>;
databaseUri: string;
sourceLocationPrefix: string;
run?: Run;
Expand Down
4 changes: 3 additions & 1 deletion extensions/ql-vscode/src/view/results/__tests__/AlertTablePathRow.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import { createMockResults } from "../../../../test/factories/results/mockresult

describe(AlertTablePathRow.name, () => {
const render = (props?: Props) => {
const mockRef = { current: null } as React.RefObject<HTMLTableRowElement>;
const mockRef = {
current: null,
} as React.RefObject<HTMLTableRowElement | null>;
const results = createMockResults();
const threadFlow = results[0]?.codeFlows?.[0]?.threadFlows?.[0];

Expand Down
4 changes: 3 additions & 1 deletion extensions/ql-vscode/src/view/results/__tests__/AlertTableResultRow.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import { createMockResults } from "../../../../test/factories/results/mockresult

describe(AlertTableResultRow.name, () => {
const render = (props?: Props) => {
const mockRef = { current: null } as React.RefObject<HTMLTableRowElement>;
const mockRef = {
current: null,
} as React.RefObject<HTMLTableRowElement | null>;
const results = createMockResults();

reactRender(
Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/view/results/useScrollIntoView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { RefObject } from "react";
import { useEffect } from "react";

export function useScrollIntoView<T>(
export function useScrollIntoView<T, E extends HTMLElement = HTMLElement>(
selectedElement: T | undefined,
selectedElementRef: RefObject<HTMLElement>,
selectedElementRef: RefObject<E | null>,
) {
useEffect(() => {
const element = selectedElementRef.current;
Expand Down