feat(shell): add fish support to `create-new-feature` #1361

Francesco146 · 2025-12-20T08:00:49Z

No description provided.

Copilot

Pull request overview

This PR adds Fish shell support to the create-new-feature script, providing an alternative implementation for Fish shell users alongside the existing Bash version.

Implements full feature creation workflow including argument parsing, branch name generation, and spec file setup
Translates Bash script logic to Fish shell syntax while maintaining functional equivalence
Supports JSON output mode, custom short names, and manual branch numbering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-20T08:05:44Z

scripts/fish/create-new-feature.fish

+            echo "Usage: create-new-feature.fish [--json] [--short-name <name>] [--number N] <feature_description>"
+            echo ""
+            echo "Options:"
+            echo "  --json              Output in JSON format"
+            echo "  --short-name <name> Provide a custom short name (2-4 words) for the branch"
+            echo "  --number N          Specify branch number manually (overrides auto-detection)"
+            echo "  --help, -h          Show this help message"
+            echo ""
+            echo "Examples:"
+            echo "  create-new-feature.fish 'Add user authentication system' --short-name 'user-auth'"
+            echo "  create-new-feature.fish 'Implement OAuth2 integration for API' --number 5"


The help text uses a hardcoded script name instead of a variable. The bash version uses $0 to dynamically show the script name that was invoked, which is more flexible and accurate. This fish version should use something like (status --current-filename) or basename of it to match the bash behavior and show the actual invoked script name.

Copilot · 2025-12-20T08:05:44Z

scripts/fish/create-new-feature.fish

+    # Convert to lowercase and split into words
+    set clean_name (echo $description | string lower | sed 's/[^a-z0-9]/ /g')
+
+    # Filter words


Comment differs from bash version. The bash version says "Filter words: remove stop words and words shorter than 3 chars (unless they're uppercase acronyms in original)" which is more descriptive. The fish version says "Filter words" followed by "Keep words that are NOT stop words AND (length >= 3 OR are potential acronyms)" in a later comment. Consider matching the bash version's comment style for consistency.

Suggested change

# Filter words

# Filter words: remove stop words and words shorter than 3 chars (unless they're uppercase acronyms in original)

Copilot · 2025-12-20T08:05:45Z

scripts/fish/create-new-feature.fish

+    exit 1
+end
+
+# Function to find the repository root


Missing explanatory comment. The bash version has "Function to find the repository root by searching for existing project markers" which is more descriptive than just "Function to find the repository root". The additional context about "searching for existing project markers" helps explain what the function does. Consider adding this for better documentation.

Suggested change

# Function to find the repository root

# Function to find the repository root by searching for existing project markers

Copilot · 2025-12-20T08:05:45Z

scripts/fish/create-new-feature.fish

+            else if echo $description | string match -q "*"(string upper $word)"*"
+                # Keep short words if they appear as uppercase in original


The acronym detection logic differs from the bash version. The bash version checks if the word appears as uppercase in the original description using grep -q "\b${word^^}\b" with word boundaries. The fish version uses string match -q "*"(string upper $word)"*" which performs a substring match and could produce false positives. For example, if the word "id" appears anywhere in "valid", it would match. Consider using a more precise matching approach.

Suggested change

else if echo $description | string match -q "*"(string upper $word)"*"

# Keep short words if they appear as uppercase in original

else if echo $description | grep -q -w (string upper $word)

# Keep short words if they appear as uppercase in original as a whole word

Copilot · 2025-12-20T08:05:45Z

scripts/fish/create-new-feature.fish

+function check_existing_branches
+    set specs_dir $argv[1]
+
+    # Fetch all remotes


Missing comment about remote fetching. The bash version has "Fetch all remotes to get latest branch info (suppress errors if no remotes)" which explains both the action and the error suppression strategy. The fish version lacks this comment. Consider adding it for better documentation.

Suggested change

# Fetch all remotes

# Fetch all remotes to get latest branch info (suppress errors if no remotes)

Copilot · 2025-12-20T08:05:47Z

scripts/fish/create-new-feature.fish

+end
+
+# Force base-10 interpretation
+set FEATURE_NUM (printf "%03d" (math $BRANCH_NUMBER + 0))


Missing base-10 interpretation prefix. The bash version uses $((10#$BRANCH_NUMBER)) to force base-10 interpretation and prevent octal conversion (e.g., "010" being interpreted as octal 8 instead of decimal 10). The fish version only uses (math $BRANCH_NUMBER + 0) which may not handle this edge case correctly. This could lead to incorrect branch numbering when branch numbers like 008, 009, 010, etc. are provided.

Copilot · 2025-12-20T08:05:47Z

scripts/fish/create-new-feature.fish

+set FEATURE_NUM (printf "%03d" (math $BRANCH_NUMBER + 0))
+set BRANCH_NAME "$FEATURE_NUM-$BRANCH_SUFFIX"
+
+# GitHub enforces a 244-byte limit on branch names


Missing comment for branch name validation section. The bash version includes a comment "Validate and truncate if necessary" after the main comment about GitHub's 244-byte limit. This helps clarify the purpose of the following code block. Consider adding this comment for consistency and clarity.

Suggested change

# GitHub enforces a 244-byte limit on branch names

# GitHub enforces a 244-byte limit on branch names

# Validate and truncate if necessary

Copilot · 2025-12-20T08:05:48Z

scripts/fish/create-new-feature.fish

+    echo $name | string lower | sed 's/[^a-z0-9]/-/g' | sed 's/-\+/-/g' | sed 's/^-//' | sed 's/-$//'
+end
+
+# Resolve repository root


Missing detailed comment about repository root detection. The bash version includes an explanatory comment: "Resolve repository root. Prefer git information when available, but fall back to searching for repository markers so the workflow still functions in repositories that were initialised with --no-git." This provides important context about the design decision. Consider adding this comment for better maintainability.

Suggested change

# Resolve repository root

# Resolve repository root. Prefer git information when available, but fall back

# to searching for repository markers so the workflow still functions in

# repositories that were initialised with --no-git.

Copilot · 2025-12-20T08:05:48Z

scripts/fish/create-new-feature.fish

+    end
+end
+
+# Force base-10 interpretation


Inconsistent comment format. The bash version has a more detailed comment explaining "Force base-10 interpretation to prevent octal conversion (e.g., 010 → 8 in octal, but should be 10 in decimal)". This fish version only says "Force base-10 interpretation" without the helpful explanation. For maintainability and clarity, consider adding the full explanation as in the bash version.

Suggested change

# Force base-10 interpretation

# Force base-10 interpretation to prevent octal conversion (e.g., 010 → 8 in octal, but should be 10 in decimal)

Copilot · 2025-12-20T08:05:48Z

scripts/fish/create-new-feature.fish

+        # Fallback to original logic
+        set cleaned (clean_branch_name $description)
+        echo $cleaned | string split '-' | string match -v '' | head -3 | string join '-'


The fallback branch name generation logic differs from the bash version. The bash version uses tr '\n' '-' | sed 's/-$//' to join words and remove trailing hyphens, while the fish version uses string join '-'. While both achieve similar results, the bash version explicitly processes the cleaned output through tr '-' '\n' | grep -v '^$' | head -3 to split, filter empty strings, take first 3, then rejoin. The fish version uses string split '-' | string match -v '' | head -3 | string join '-' which should work equivalently. However, verify this produces identical results in edge cases.

Suggested change

# Fallback to original logic

set cleaned (clean_branch_name $description)

echo $cleaned | string split '-' | string match -v '' | head -3 | string join '-'

# Fallback to original logic (match bash implementation)

set cleaned (clean_branch_name $description)

echo $cleaned | tr '-' '\n' | grep -v '^$' | head -3 | tr '\n' '-' | sed 's/-$//'

feat(shell): add fish support to create-new-feature

3372824

Copilot AI review requested due to automatic review settings December 20, 2025 08:00

Francesco146 requested a review from localden as a code owner December 20, 2025 08:00

Copilot started reviewing on behalf of Francesco146 December 20, 2025 08:01 View session

Copilot AI reviewed Dec 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(shell): add fish support to `create-new-feature` #1361

feat(shell): add fish support to `create-new-feature` #1361

Uh oh!

Francesco146 commented Dec 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Copilot AI Dec 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	# Filter words
	# Filter words: remove stop words and words shorter than 3 chars (unless they're uppercase acronyms in original)

	# Function to find the repository root
	# Function to find the repository root by searching for existing project markers

		else if echo $description \| string match -q ""(string upper $word)""
		# Keep short words if they appear as uppercase in original

	# Fetch all remotes
	# Fetch all remotes to get latest branch info (suppress errors if no remotes)

	# GitHub enforces a 244-byte limit on branch names
	# GitHub enforces a 244-byte limit on branch names
	# Validate and truncate if necessary

-# Resolve repository root
+# Resolve repository root. Prefer git information when available, but fall back
+# to searching for repository markers so the workflow still functions in
+# repositories that were initialised with --no-git.

	# Force base-10 interpretation
	# Force base-10 interpretation to prevent octal conversion (e.g., 010 → 8 in octal, but should be 10 in decimal)

feat(shell): add fish support to create-new-feature #1361

Are you sure you want to change the base?

feat(shell): add fish support to create-new-feature #1361

Uh oh!

Conversation

Francesco146 commented Dec 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat(shell): add fish support to `create-new-feature` #1361

feat(shell): add fish support to `create-new-feature` #1361