Update some snapshots; remove redundant ones #52
Merged
+40
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up test snapshots by removing orphaned snapshots for the deprecated ask and query APIs, and updating remaining snapshots to reflect current system behavior.
Changes:
- Removed 7 orphaned snapshot files for removed
askandqueryAPIs - Updated 6 snapshot files to reflect current assistant responses and tool call behaviors
- Simplified duplicate test conversations in the tools snapshot
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/query/should_support_resume_option_for_multi_turn_conversations.yaml | Deleted orphaned snapshot for removed query API |
| test/snapshots/query/should_stream_events_and_return_assistant_message.yaml | Deleted orphaned snapshot for removed query API |
| test/snapshots/permissions/should_invoke_permission_handler_for_shell_commands.yaml | Deleted orphaned snapshot |
| test/snapshots/customagents/accept_custom_agent_config_on_resume.yaml | Deleted orphaned snapshot |
| test/snapshots/combinedconfiguration/accept_mcp_servers_and_custom_agents.yaml | Deleted orphaned snapshot |
| test/snapshots/ask/should_return_assistant_message_content.yaml | Deleted orphaned snapshot for removed ask API |
| test/snapshots/ask/should_invoke_onevent_callback_for_each_event.yaml | Deleted orphaned snapshot for removed ask API |
| test/snapshots/tools/invokes_built_in_tools.yaml | Removed duplicate conversation and simplified structure |
| test/snapshots/permissions/should_resume_session_with_permission_handler.yaml | Updated assistant responses and function argument ordering |
| test/snapshots/permissions/should_invoke_permission_handler_for_write_operations.yaml | Added intermediate assistant content messages |
| test/snapshots/permissions/should_handle_permission_handler_errors_gracefully.yaml | Updated function argument descriptions |
| test/snapshots/permissions/permission_handler_for_shell_commands.yaml | Updated test command and added detailed output explanation |
| test/snapshots/permissions/async_permission_handler.yaml | Refined assistant response wording |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
friggeri
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some orphaned snapshots, particularly for
askandquery(those APIs were removed).